Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Move app menu into new stacked header #77954

Closed
5 tasks
ryankeairns opened this issue Sep 18, 2020 · 2 comments
Closed
5 tasks

[Canvas] Move app menu into new stacked header #77954

ryankeairns opened this issue Sep 18, 2020 · 2 comments
Assignees
Labels
Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 18, 2020

With the introduction of the new global, stacked header, application menus are now being relocated into the lower bar as seen below:

Screen Shot 2020-12-02 at 2 12 22 PM

For consistency, it would be preferable that Canvas followed suit (ideally for 7.10). This can be accomplished using the shared TopNavMenu component which has been adapted to leverage a new API which pushes the menu into the header. For reference, other Kibana apps such as Discover, Dashboard, and Lens have already been converted.

Proposed changes

  • Convert the current Canvas menu to use the shared TopNavMenu component
  • Change 'View' to 'Options' to align with terminology used in Dashboard
  • Change the order to: 'Options', 'Share', and 'Edit' (again, following the Dashboard order)
  • Add the V1 toolbar / Keep the 'Add element' button in its current place (perhaps pushed into the new toolbar component)
  • Remove 'Add from Kibana' from the 'Add element' context menu. Instead, use the 'Add from Library' button to open the embeddables/library flyout

TopNavMenu component

https://github.com/elastic/kibana/blob/61c4e6fd8d7410bfabe3d108211d7aa1d54c7ef5/src/plugins/navigation/public/top_nav_menu/top_nav_menu.tsx

Alignment with Dashboard

Dashboard is planning to add a new tooblar which could be leveraged in Canvas for similar purposes (e.g. adding content from the library).

Dashboard V1 toolbar (proposed)

Screen Shot 2020-12-02 at 2 17 01 PM

Canvas V1 toolbar (proposed)

Screen Shot 2020-12-02 at 2 12 37 PM

cc:/ @alexfrancoeur

@ryankeairns ryankeairns added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Sep 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@cqliu1 cqliu1 added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels Nov 23, 2020
@nreese
Copy link
Contributor

nreese commented Apr 6, 2023

Closing as not planned

@nreese nreese closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants