Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Allow fields to be dragged from the field list to the dimension flyout #78155

Closed
AlonaNadler opened this issue Sep 22, 2020 · 6 comments
Closed
Labels
enhancement New value added to drive a business result Feature:Lens loe:medium Medium Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@AlonaNadler
Copy link

The new flyout visually makes lens configuration more organized and allows to add more configurations.
When dragging a field to replace existing field Lens doesn't show the highlighting. The highlighting helps understand this is a droppable place

cc: @cchaos

@AlonaNadler AlonaNadler added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon added enhancement New value added to drive a business result needs design labels Sep 22, 2020
@flash1293
Copy link
Contributor

Just to make sure - we are talking about this scenario, right?
Screenshot 2020-09-22 at 18 27 29

Hovering over the field input with the e.keyword field does not indicate in any way I can drop it here.

@AlonaNadler
Copy link
Author

Yes correct @flash1293

@wylieconlon wylieconlon changed the title Add Lens highlight as droppable when on the configuration flyout [Lens] Allow fields to be dragged from the data panel to the dimension editor Sep 23, 2020
@wylieconlon wylieconlon changed the title [Lens] Allow fields to be dragged from the data panel to the dimension editor [Lens] Allow fields to be dragged from the field list to the dimension flyout Nov 5, 2020
@wylieconlon wylieconlon added the loe:medium Medium Level of Effort label Nov 10, 2020
@wylieconlon
Copy link
Contributor

The request is pretty clear. From a technical side we need to verify that the DragDropContext is available this far in the component hierarchy, especially because DragDropContext is owned by the editor frame and not the datasource. The other potential concern is that the droppable styles might interface with the interactivity of the field selector, so we might need some kind of alternative drop target.

@flash1293
Copy link
Contributor

I'm not sure whether this is still a valid request - with #78195 we changed the behavior to closing the flyout if something outside of it is clicked. Because of this it's no longer possible to drag a field from the data panel into the field select in the flyout. @AlonaNadler do you think we should do something else here?

@AlonaNadler
Copy link
Author

Playing with master that seem to no longer be a problem. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens loe:medium Medium Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants