Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Update User Experience app callout code to reflect new name #78728

Closed
formgeist opened this issue Sep 29, 2020 · 6 comments · Fixed by #80641
Closed

[APM] Update User Experience app callout code to reflect new name #78728

formgeist opened this issue Sep 29, 2020 · 6 comments · Fixed by #80641
Assignees
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture

Comments

@formgeist
Copy link
Contributor

formgeist commented Sep 29, 2020

Summary

The naming was changed so we should update the function names in the code to reflect those to avoid misleading or confusing references to legacy app names.

Screenshot 2020-09-29 at 09 47 20

@formgeist formgeist added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.10.0 labels Sep 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@shahzad31
Copy link
Contributor

i think this is already updated.

@formgeist
Copy link
Contributor Author

Ah apologies, I didn't notice the copy did change. I still think it makes sense to update the function naming or WDYT?

@shahzad31
Copy link
Contributor

ohh yes , code didn't change , i am planing on doing another PR to update coding names, so maybe keep this open until that is fixed

@formgeist
Copy link
Contributor Author

@shahzad31 sounds good - I'll update the issue title and description

@formgeist formgeist changed the title [APM] Update User Experience app callout code and description copy [APM] Update User Experience app callout code to reflect new name Sep 29, 2020
@formgeist formgeist added technical debt Improvement of the software architecture and operational architecture and removed v7.10.0 labels Sep 29, 2020
@sorenlouv
Copy link
Member

@shahzad31 Are you still planning to do this for 7.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM - DEPRECATED Use Team:obs-ux-infra_services. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants