Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circular dependency between discover & visualizations plugins #80511

Closed
mshustov opened this issue Oct 14, 2020 · 2 comments · Fixed by #82248
Closed

Remove circular dependency between discover & visualizations plugins #80511

mshustov opened this issue Oct 14, 2020 · 2 comments · Fixed by #82248
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mshustov
Copy link
Contributor

discover plugin lists visualizations in requiredPlugins, while visualizations declares discover plugin as requiredBundles.
We need to remove circular dependency to unblock plugin migration to TS project refs #80508 and migration to the new build chain #69706
@mshustov mshustov added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mshustov mshustov mentioned this issue Oct 14, 2020
Closed
@timroes timroes added the Feature:Discover Discover Application label Oct 20, 2020
@timroes
Copy link
Contributor

timroes commented Oct 20, 2020

The way we should resolve that is by making Discover not require the visualizations plugin anymore. It's solely using it for the purpose of creating a vis for the histogram bar chart. Actually we never need that Vis object in discover and instead we could and should just request the data using esaggs directly and input that into the custom renderer we're using in discover. Solving this issue, will automatically also solve #69134 which we anyway planned to do soon.

@timroes timroes mentioned this issue Oct 27, 2020
Closed
@kertal kertal mentioned this issue Nov 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Remove visualize dependency kertal/kibana
3 participants
@timroes @mshustov @elasticmachine