Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Simplify EMS config for on-prem configs #80865

Closed
thomasneirynck opened this issue Oct 16, 2020 · 7 comments · Fixed by #82525
Closed

[Maps] Simplify EMS config for on-prem configs #80865

thomasneirynck opened this issue Oct 16, 2020 · 7 comments · Fixed by #82525
Assignees
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.11.0 v8.0.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Oct 16, 2020

Describe the feature:

Currently, EMS needs to be configured with three URLs.

map.emsFileApiUrl
map.emsTileApiUrl
map.emsFontLibraryUrl

There's also a link to the public website:

map.emsLandingPageUrl

These are all undocumented internal configs.

Describe a specific use case for the feature:

As EMS will become available on-prem, we can simplify this config to a single setting. All 4 resources will be hosted locally then.

@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.11.0 labels Oct 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck changed the title [Maps] Simplify local EMS config for on-prem configs [Maps] Simplify EMS config for on-prem configs Oct 16, 2020
@thomasneirynck thomasneirynck self-assigned this Oct 20, 2020
@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Oct 29, 2020

I'd propose the following:

  1. Introduce new publicly documented setting:
map.emsUrl: http://localhost:8080

From these, the 4 endpoints will be dynamically constructed:

-> FileApiUrl: append tile.
-> TileApiUrl: append file
-> Font api: append tile/fonts/{fontstack}/{range}.pbf
-> landing page: append maps

  1. Retain the original settings. These will remain internal and undocumented.
map.emsFileServiceUrl
map.emsTileServiceUrl
map.emsFontLibraryUrl
map.emsLandingPageUrl

These are hardcoded in the Kibana source-code.


Why can we not just introduce maps.emsUrl and remove the 4 legacy settings?

For the publically hosted EMS, the files, tiles, and landing page all reside on a different host. There is not really an algorithmic way to construct the urls from a root path. Also, it might still be useful to configure these in isolation so we can test staged or test versions of the tile and file service.

@nickpeihl
Copy link
Member

nickpeihl commented Oct 29, 2020

lgtm.

  1. Introduce new publicly documented setting:
map.emsUrl: http://localhost:8080

Should this new setting also be restricted to the specific license for on-prem maps?

From these, the 4 endpoints will be dynamically constructed:

-> FileApiUrl: append tile.
-> TileApiUrl: append file
-> Font api: append file/fonts/{fontstack}/{range}.pbf
-> landing page: append v7.10 (or whatever the version number)

Couple of endpoint corrections:
Font api: append /tile/fonts/{fontStack}/{range}.pbf
landing page: append /maps (no version number necessary)

@thomasneirynck
Copy link
Contributor Author

thx, added the corrections.

Should this new setting also be restricted to the specific license for on-prem maps?

Interesting. What should the behavior be? Log a warning to the console?

@nickpeihl
Copy link
Member

Interesting. What should the behavior be? Log a warning to the console?

I was thinking we could log a warning, but I don't feel too strongly about this. License verification should already be handled by the on-prem maps service.

@thomasneirynck
Copy link
Contributor Author

+1 on warning to console. It'd be helpful agreed.

@jsanz
Copy link
Member

jsanz commented Nov 5, 2020

Since there's a license check in the OnPrem EMS, I think it would make sense to also check it on the Kibana side to honor the setting only for enterprise level clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants