Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry] Schema disallow "number" #81597

Closed
Bamieh opened this issue Oct 26, 2020 · 3 comments · Fixed by #81774
Closed

[Telemetry] Schema disallow "number" #81597

Bamieh opened this issue Oct 26, 2020 · 3 comments · Fixed by #81774
Assignees
@Bamieh
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bamieh
Copy link
Member

Bamieh commented Oct 26, 2020

We have a few places where we have number as the schema type. We need to only allow explicit types for numbers to help build the ES mapping (int, long, double).

example: security.authProviderCount.type: number
@Bamieh Bamieh self-assigned this Oct 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@TinaHeiligers
Copy link
Contributor

It goes without saying that we'll need to update the instructions too 😉

@Bamieh Bamieh mentioned this issue Oct 27, 2020
Merged
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bamieh Bamieh

Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Telemetry] [Schema] remove number type and support all es number types Bamieh/kibana
4 participants
@lukeelmers @Bamieh @TinaHeiligers @elasticmachine