Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Remove Coordinate map and region map visualizations #81703

Closed
nreese opened this issue Oct 27, 2020 · 9 comments
Closed

[Breaking change] Remove Coordinate map and region map visualizations #81703

nreese opened this issue Oct 27, 2020 · 9 comments

Comments

@nreese
Copy link
Contributor

nreese commented Oct 27, 2020

Change description

Which release will ship the breaking change?

8.0

Describe the change. How will it manifest to users?

tile_map, region_map, and maps_legacy plugins will be removed from the kibana baseline. This will remove Coordinate map and region map visualizations from Kibana visualize library.

How many users will be affected?

What can users do to address the change manually?

Starting in 7.10, coordinate map and region map contain a View in maps button that will migrate their coordinate map or region map configuration to the Maps application (#77683). This provides users with the ability to test out the migration in 7.x releases prior to 8.0

How could we make migration easier with the Upgrade Assistant?

The upgrade assistant should convert all tile_map and region_map visualization saved objects to map saved objects. The upgrade assistant will also have to update any dashboard or canvas that embeds these migrated visualizations.

Are there any edge cases?

Test Data

Manually creating coordinate map and region map visualizations

  1. To show coordinate map and region map visualizations in "Create new" menu, add xpack.maps.showMapVisualizationTypes: true to kibana.dev.yml
  2. Then, create coordinate map and region map visualizations just like any other "Aggregation based" visualization. Open "visualize" and click "Create visualization", Select "Aggregation based", finally select "Coordinate map" or "Region map".

Coordinate map configuration for kibana_sample_data_logs
Screen Shot 2020-11-18 at 6 58 39 AM

Region map configuration for kibana_sample_data_logs
Screen Shot 2020-11-18 at 7 00 31 AM

Manually creating region map visualization using map.regionmap vector layer.

  1. Add the following to kibana.dev.yml

    map.regionmap:
     layers:
      - attribution: "EMS"
        name: "My copy of world countries"
        url: "https://vector.maps.elastic.co/files/world_countries_v7.geo.json?elastic_tile_service_tos=agree&my_app_name=ems-landing-page&my_app_version=7.10.0&license=643c1faf-80fc-4ab0-9323-4d9bd11f4bbc"
        fields:
         - name: "name"
           description: "Name"
         - name: "iso2"
           description: "iso2"
    
  2. Create region map as described above

  3. Configure region map to use world countries layer defined in map.regionmap by opening "Options" tag and using the configuraitons below
    Screen Shot 2020-11-18 at 9 09 08 AM

Import pre-made saved objects for kibana_sample_data_logs that include edge cases

TBD

Cross links

None

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Upgrade Assistant Breaking Change labels Oct 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kobelb kobelb added NeededFor:Geo Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Oct 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor

@nreese would you mind adding details to the Test Data section? I think providing steps or pointing to docs on the best way to set up coordinate map and region map visualizations would be helpful.

@nreese
Copy link
Contributor Author

nreese commented Nov 18, 2020

would you mind adding details to the Test Data section?

I added some details for creating region map and coordinate map visualizations. I will update with an example with map.regionmap configuration later today and with a exported saved object ndjson file in a few weeks once we start to think about the upgrade assistent and the test cases we want for that.

@kobelb
Copy link
Contributor

kobelb commented Dec 14, 2020

@nreese do we have any idea how may users are likely to hit this breaking change?

@alisonelizabeth
Copy link
Contributor

I'm going to remove the Elasticsearch UI team label. This deprecation should be registered by the plugin owner via the core deprecations service (#94845). All registered deprecations will be displayed in the Upgrade Assistant (to be implemented via #97159). Feel free to reach out to myself or the core team with any questions!

@thomasneirynck
Copy link
Contributor

support of equivalent to min_doc_count should be introduced in Maps.

@nreese
Copy link
Contributor Author

nreese commented Aug 18, 2021

closed by #105326

@nreese nreese closed this as completed Aug 18, 2021
@cjcenizal
Copy link
Contributor

Thanks for updating this @nreese! Could you please update #109166?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants