Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Remove visible title in workspace panel #81979

Closed
flash1293 opened this issue Oct 29, 2020 · 5 comments · Fixed by #82234
Closed

[Lens] Remove visible title in workspace panel #81979

flash1293 opened this issue Oct 29, 2020 · 5 comments · Fixed by #82234
Assignees
@lykims
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Currently we show the title of the chart in the workspace, but it's also part of the breadcrumb ("doublelayer" in this case):

Screenshot 2020-10-28 at 18 22 37

As Visualization titles are less relevant with the move to dashboard-embedded visualizations, it makes sense to gain back the vertical space for the chart itself.

The title should still be kept for screenreaders for a11y reasons
@flash1293 flash1293 added good first issue low hanging fruit enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this issue Oct 29, 2020
Closed
@lykims
Copy link
Contributor

lykims commented Oct 30, 2020

Hi! I'd like to work on this.

@flash1293
Copy link
Contributor Author

Hi @lykims thanks for offering support 💚 Unfortunately there is a PR open currently fixing something in the same area which would conflict with this work: #81752

I'll let you know when this issue is unblocked.

@flash1293
Copy link
Contributor Author

@lykims That was a short wait - #81752 is merged, so feel free to work on this. I'm going to assign the issue to you, let me know if you can't work on it anymore for any reason.

@lykims
Copy link
Contributor

lykims commented Oct 30, 2020

Thank you, Joe!

@lykims lykims mentioned this issue Nov 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lykims lykims

Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Remove visible title in workspace panel lykims/kibana
3 participants
@flash1293 @lykims @elasticmachine