Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] TS project references migration #82220

Closed
16 tasks done
jfsiii opened this issue Oct 31, 2020 · 7 comments · Fixed by #87574
Closed
16 tasks done

[Fleet] TS project references migration #82220

jfsiii opened this issue Oct 31, 2020 · 7 comments · Fixed by #87574
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0

Comments

@jfsiii
Copy link
Contributor

jfsiii commented Oct 31, 2020

Summary

Now that the Kibana build system supports using TypeScript project references (#46773), the fleet plugin must be migrated to participate. This is part of the overall effort tracked at #80508.

Acceptance criteria

See PR at #87574
The fleet plugin can be referred to using a project reference, which means it...

Related information

@jfsiii jfsiii added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii
Copy link
Contributor Author

jfsiii commented Oct 31, 2020

Tagged as 7.11 & 7.12 see #80508 (comment) & #80508 (comment)

@ph ph removed the v7.11.0 label Jan 5, 2021
@ph
Copy link
Contributor

ph commented Jan 5, 2021

Thanks @jfsiii for creating this, one question do you know the background in why in the meta issue (#80508) it's marked that the kibana platform will do it? Is is because of the dependencies? Could you take the lead on that effort for 7.12, looking at the weekly kibana update there is a hard deadline for 7.12 on this change.

@ph ph assigned jfsiii Jan 5, 2021
@ph
Copy link
Contributor

ph commented Jan 5, 2021

Also, what is the effort for us to migrate to TS project? Are we talking hours, days, or more?

@jfsiii jfsiii changed the title [IngestManager] TS project references migration [Fleet] TS project references migration Jan 5, 2021
@jfsiii
Copy link
Contributor Author

jfsiii commented Jan 5, 2021

@ph I missed that update, but it looks like @restrry updated it back in November.

Screen Shot 2021-01-05 at 10 36 27 AM

Regarding scope, I'm not sure. I believe the work is dominated/dependent on the plugins listed in the description (data, security, features, etc) but let me look more into the Fleet code and ask around and I'll come back with an update.

@restrry, are you / platform working on this? Do you need anything from me / Fleet? I'm happy to help any way I can. I'll also probably drop in the Slack channel soon to ask some questions.

@ph
Copy link
Contributor

ph commented Jan 5, 2021

Thanks @jfsiii for coordinating that effort.

@mshustov
Copy link
Contributor

mshustov commented Jan 6, 2021

@jfsiii your help is appreciated if you have the capacity for it.
I assigned it to the Core team since I wasn't sure whether the plugin is maintained by anyone.

@jfsiii jfsiii linked a pull request Jan 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants