Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console UI should not depend on elasticsearch.url #8233

Closed
spalger opened this issue Sep 12, 2016 · 4 comments
Closed

Console UI should not depend on elasticsearch.url #8233

spalger opened this issue Sep 12, 2016 · 4 comments
Labels
chore Feature:Console Dev Tools Console Feature help wanted adoptme Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@spalger
Copy link
Contributor

spalger commented Sep 12, 2016

Now that console does not accept a url and has been turned into a devtool it needs to stop relying on the elasticsearchUrl injected var.

Right now, it has to inject the elasticsearch.url configuration value into the default injected vars since the ability to extend the devTools specifically is not provided.

To prevent other applications from becoming dependent on this value, we should remove it use in the console code and from the default injected vars.

@spalger spalger mentioned this issue Sep 12, 2016
@cjcenizal cjcenizal changed the title Console UI should not depended on elasticsearch.url Console UI should not depend on elasticsearch.url Sep 12, 2016
@ycombinator
Copy link
Contributor

ycombinator commented Sep 15, 2016

Note that the elasticsearchUrl var is required by the Console client-side code to generate the curl form of the request.

So while I agree that this var should not be injected via injectDefaultVars to prevent other applications becoming dependent on its value, we will still need some way for the Console client-side code to access this value. When Console was a top-level app, we could've used injectVars (in place of injectDefaultVars) but I'm not sure how to achieve the same effect now.

@spalger
Copy link
Contributor Author

spalger commented Sep 16, 2016

Interesting, definitely an obstacle

@timroes timroes added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed :Management DO NOT USE labels Nov 27, 2018
@cjcenizal
Copy link
Contributor

Somewhat relates to #32845.

@jloleysens
Copy link
Contributor

jloleysens commented Apr 20, 2021

@spalger we are doing some housekeeping with these issues, I just wanted to check with you whether this issue is still relevant with respect to use of "injectedVars". It looks like console now gets this value from CoreSetup.elasticsearch.legacy.config$ where it then extracts the hosts array that was configured in kibana.yml.

This sounds like we have addressed the issue raised here? Possibly that the issue has just taken a different form since this was created 😅 . Let me know what you think!

[EDIT]
Additionally, the front end now gets this value at a specific endpoint from Console.

@spalger spalger closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Console Dev Tools Console Feature help wanted adoptme Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

6 participants