-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console UI should not depend on elasticsearch.url
#8233
Comments
elasticsearch.url
elasticsearch.url
Note that the So while I agree that this var should not be injected via |
Interesting, definitely an obstacle |
Somewhat relates to #32845. |
@spalger we are doing some housekeeping with these issues, I just wanted to check with you whether this issue is still relevant with respect to use of "injectedVars". It looks like console now gets this value from This sounds like we have addressed the issue raised here? Possibly that the issue has just taken a different form since this was created 😅 . Let me know what you think! [EDIT] |
Now that console does not accept a url and has been turned into a devtool it needs to stop relying on the
elasticsearchUrl
injected var.Right now, it has to inject the
elasticsearch.url
configuration value into the default injected vars since the ability to extend the devTools specifically is not provided.To prevent other applications from becoming dependent on this value, we should remove it use in the console code and from the default injected vars.
The text was updated successfully, but these errors were encountered: