Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UsageCollection] Create StatsCollector as an extension of Collector #83522

Closed
afharo opened this issue Nov 17, 2020 · 4 comments
Closed

[UsageCollection] Create StatsCollector as an extension of Collector #83522

afharo opened this issue Nov 17, 2020 · 4 comments
Assignees
@afharo
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Nov 17, 2020

An aside: We're being explicit about defining a different UsageCollector class from the Collector class and I wonder if it would be more consistent if we had a base Collector class and extended it to a new StatsCollector class even if we're not actually extending the Collector 🤔

Originally posted by @TinaHeiligers in #83413 (comment)
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo afharo mentioned this issue Nov 17, 2020
Merged
3 tasks
@TinaHeiligers
Copy link
Contributor

Thanks for creating this issue @afharo !
I don't think it's urgent and probably doesn't need to happen for 7.11. You certainly have other work that's higher priority.
We can add this ticket to the planning session.

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:KibanaTelemetry labels Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo mentioned this issue Dec 10, 2020
Closed
1 task
@afharo afharo self-assigned this Dec 10, 2020
@afharo
Copy link
Member Author

afharo commented Dec 18, 2020

Closing the issue for now. The reasons are in this discussion: #85554 (comment)

We can revisit it whenever we actually need a differentiation 🙂

@afharo afharo closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore][UsageCollection] StatsCollector explicit class afharo/kibana
3 participants
@afharo @TinaHeiligers @elasticmachine