Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security solutions cypress tests should be triggered on PRs related to alerts and actions #83851

Open
ymao1 opened this issue Nov 19, 2020 · 1 comment
Open

Security solutions cypress tests should be triggered on PRs related to alerts and actions #83851

ymao1 opened this issue Nov 19, 2020 · 1 comment
Labels
Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@ymao1
Copy link
Contributor

ymao1 commented Nov 19, 2020 •
edited
Loading

Currently, the security solutions cypress tests are only triggered when changes occur in certain plugin paths:
https://github.com/elastic/kibana/blob/master/vars/tasks.groovy#L117-L122

However there are other plugin changes that might affect the cypress tests. It would be nice to run the tests on PRs that touch the plugins/alerts and plugins/actions paths, maybe event plugins/task_manager?

The latest example was this PR: #83578 which passed the build during the PR stage but caused immediate cypress test failures when merged into master.

Previous discussion related to this can be found here: #73939 (comment)
@ymao1 ymao1 mentioned this issue Nov 19, 2020
Merged
1 task
@dhurley14 dhurley14 added Team:Detections and Resp Security Detection Response Team Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 19, 2020
@lizozom
Copy link
Contributor

lizozom commented Nov 23, 2020

We just hit the same problem with a change to the data plugin #83418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhurley14 @lizozom @ymao1