Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/smokescreen·ts - lens app lens smokescreen tests should be able to add very long labels and still be able to remove a dimension #85001

Closed
kibanamachine opened this issue Dec 4, 2020 · 5 comments · Fixed by #85042
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 4, 2020

A test failed on a tracked branch

Error: expected 'Test of labelVeryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryvery long label wrapping multiple lines' to sort of equal 'Veryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryvery long label wrapping multiple lines'
    at Assertion.assert (/dev/shm/workspace/parallel/21/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/21/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.<anonymous> (test/functional/apps/lens/smokescreen.ts:184:90)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at Object.apply (/dev/shm/workspace/parallel/21/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16) {
  actual: 'Test of labelVeryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryvery long label wrapping multiple lines',
  expected: 'Veryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryvery long label wrapping multiple lines',
  showDiff: true
}

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Dec 4, 2020
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@mistic mistic added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Dec 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@flash1293
Copy link
Contributor

This is strange, it seems like testSubjects.setValue is not able to reliably reset the label before entering the new value:

await testSubjects.setValue('indexPattern-label-edit', label);

My best guess it's related to the debouncing logic of the label (

const LabelInput = ({ value, onChange }: { value: string; onChange: (value: string) => void }) => {
) but I'm not sure how

@flash1293
Copy link
Contributor

I started a flaky runner to use clearWithKeyboard here, not sure whether that helps: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1038/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants