Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] page_header.tests.ts no longer functional #86174

Closed
dominiqueclarke opened this issue Dec 16, 2020 · 1 comment · Fixed by #86296
Closed

[Uptime] page_header.tests.ts no longer functional #86174

dominiqueclarke opened this issue Dec 16, 2020 · 1 comment · Fixed by #86296
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v7.11.0

Comments

@dominiqueclarke
Copy link
Contributor

dominiqueclarke commented Dec 16, 2020 •
edited by zube bot
Loading

In #83779 the tests were revised after removing required props and moving functionality to redux. However, the tests were not updated with the redux context in order to make the tests functional.

The tests should be updated to pass state to the redux provider, in order to test all the use cases appropriately.
@dominiqueclarke dominiqueclarke added [zube]: Backlog technical debt Improvement of the software architecture and operational architecture Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Dec 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke mentioned this issue Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] Fix/details page tabs dominiqueclarke/kibana
3 participants
@dominiqueclarke @elasticmachine @paulb-elastic