Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Table rows not clickable when using Filters aggregation #8678

Closed
hanzo opened this issue Oct 13, 2016 · 5 comments
Closed

Data Table rows not clickable when using Filters aggregation #8678

hanzo opened this issue Oct 13, 2016 · 5 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Table Data table visualization feature Feature:Filters Feature:Visualizations Generic visualization features (in case no more specific feature label is available) good first issue low hanging fruit

Comments

@hanzo
Copy link

hanzo commented Oct 13, 2016

Kibana version:
4.1.2 (hosted by AWS)

Browser version:
Latest Chrome and Safari on OS X

Description of the problem including expected versus actual behavior:
Unlike other visualization types (e.g. bar chart, pie chart), Data table visualizations created with Filters split rows aggregations are not clickable to apply the filter for the clicked row. Using Terms aggregations for Data table produces clickable rows. So this bug appears limited to Filters aggregations.

Steps to reproduce:

  1. Create a new Data table visualization
  2. Split rows using the Filters aggregation
  3. Try clicking on one of the data table rows. Expected: filter is applied. Actual: nothing happens.
@tbragin
Copy link
Contributor

tbragin commented Oct 15, 2016

I can reproduce this in 5.0, and that does seem sort of arbitrary.

@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Oct 15, 2016
@eliasramirez
Copy link

+1

@epixa epixa added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Oct 29, 2016
@tbragin tbragin added Feature:Data Table Data table visualization feature Feature:Filters labels Oct 31, 2016
@lukasolson
Copy link
Member

This seems crazy to me. This is a pretty big bug and I would think the fix wouldn't be too difficult... Thoughts @Bargs @ppisljar?

@Bargs
Copy link
Contributor

Bargs commented Mar 3, 2017

I don't see any major roadblocks to implementing it. The only slightly tricky bit is that we support both the Lucene query syntax and ES query DSL, so when creating the filter we'd have to treat them differently. We'd also probably want to use any user provided labels as the alias for the created filter, since an unknown query type would cause the raw json to be displayed in the filter UI e.g:

screen shot 2017-03-03 at 2 51 01 pm

@Bargs Bargs added :Discovery good first issue low hanging fruit labels Mar 3, 2017
@nreese nreese self-assigned this May 5, 2017
@nreese
Copy link
Contributor

nreese commented May 5, 2017

How would you test to see of the filter was an ES query DSL? Would you just check to see if it is valid JSON?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Table Data table visualization feature Feature:Filters Feature:Visualizations Generic visualization features (in case no more specific feature label is available) good first issue low hanging fruit
Projects
None yet
Development

No branches or pull requests

7 participants