Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Sessions] Restore state from SO instead of URL #87446

Closed
Tracked by #166068
Dosant opened this issue Jan 6, 2021 · 2 comments
Closed
Tracked by #166068

[Search Sessions] Restore state from SO instead of URL #87446

Dosant opened this issue Jan 6, 2021 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@Dosant
Copy link
Contributor

Dosant commented Jan 6, 2021

Part of #83640

Problem

Initial version of search session restores state from the URL.

The URL contains both serialized app + searchSessionId:

kibana/app/discover/#/?_a={discover_state}&_g={discover_state}&searchSessionId={id}

If state in the URL changes and searchSessionId stays untouched most likely session restoration would fail because search requests during restoration wouldn't match original search requests saved within the session:

Solution

By searchSessionId we can restore the application state from search session SO.

Instead of relying on rest of the app state when searchSessionId is present in the URL we could try to get the state stored in SO, so searchSessionId becomes single state source of truth.

Related

@Dosant Dosant added Feature:Search Querying infrastructure in Kibana enhancement New value added to drive a business result Team:AppServices labels Jan 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Sep 28, 2021
@petrklapka petrklapka added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:AppServicesSv labels Nov 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the Icebox label Oct 30, 2023
@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

No branches or pull requests

5 participants