Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Sessions] Reload action on management screen needs refinement #89327

Closed
Dosant opened this issue Jan 26, 2021 · 6 comments · Fixed by #90015
Closed

[Search Sessions] Reload action on management screen needs refinement #89327

Dosant opened this issue Jan 26, 2021 · 6 comments · Fixed by #90015
Labels
discuss Feature:Search Querying infrastructure in Kibana

Comments

@Dosant
Copy link
Contributor

Dosant commented Jan 26, 2021

Part of #61738
Follow up on #61741

Currently we have three actions per search session on management screen:

Screenshot 2021-01-26 at 17 42 55

Both "cancel" and "extend" have dialog that explains what is going to happen.
Reload though behaves differently:

It just navigates to the search session origin app and start a new search (a new search session) with the original state (time range/filters/query).

  1. Probably ideal behavior would be if we could rerun the session without navigating away, but as I understand, technically it isn't possible, so it is out of a picture.
  2. Another option is to show an intermediate dialog with an explanation of what is going to happen prior to navigating away. This will at least align this action with other actions and give us a chance to explain what this option does.

Without any additional explanation or confirmation, It seems that just navigating away could be very confusing because there are no ties or context to the session we are going to "reload".
We also not actually reading the search session, we just starting a new one from the same application state that we started an original one. So maybe the wording also should be changed.

Another possible reason for the confusion is the difference between "restoring" and "reloading" the session is a time range. When we "restore" a session we force the absolute time range. Currently, the original and augmented application's time range is implicit and maybe we should emphasize it somehow in mgmt UI. But this is probably a different issue.

cc @mdefazio, @lizozom

@Dosant Dosant added Feature:Search Querying infrastructure in Kibana discuss Team:AppServices labels Jan 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mdefazio
Copy link
Contributor

I like option 1, but since that's not possible, here's a 3rd option into the mix: We remove this capability from the management view and they can only 'reload' the session from the popover on the dashboard. This would avoid the modal confirmation and perhaps make it clearer that I am running a new search session.

We will also have 'Rename' in the management overflow menu, so maybe it's also nice to trim off an option here as we add a new one.

@lizozom
Copy link
Contributor

lizozom commented Jan 27, 2021

@mdefazio, if a session is expired or canceled, the only way to re-run it is from the management view, as restore is not a available altogether. :-\

@lizozom
Copy link
Contributor

lizozom commented Jan 27, 2021

@Dosant do you think it would be clearer if the action was called Re-run? I think it sounds a bit clearer that Reload which is conceptually similar to Restore.

@Dosant
Copy link
Contributor Author

Dosant commented Jan 28, 2021

it would be clearer if the action was called Re-run? I think it sounds a bit clearer than Reload which is conceptually similar to Restore.

Yes, I think I like it more!

I also think:

  • it is worth adding intermediate dialog before navigating with some explanation?
  • Our implicit relative<->absolute time range switching could be confusing. Something to think about... if we only could somehow call this behavior out and show the original time range in the mgtm screen. Maybe as part of that re-run dialog, I am thinking of.

@Dosant
Copy link
Contributor Author

Dosant commented Feb 2, 2021

Agreed to just remove the reload option from a menu for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Search Querying infrastructure in Kibana
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants