Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Create new test suite to test showMaps #89928

Closed
thomasneirynck opened this issue Feb 1, 2021 · 3 comments
Closed

[Maps] Create new test suite to test showMaps #89928

thomasneirynck opened this issue Feb 1, 2021 · 3 comments
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation test v7.16.0 v8.0.0

Comments

@thomasneirynck
Copy link
Contributor

As OSS is no longer tested, will need new test-suite to test if xpack.maps.showMapVisualizationTypes: true

The default is false.

@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.12.0 labels Feb 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor Author

Discussed offline with @tylersmalley a few weeks ago. Putting feedback here for reference.

Introducing a new test suite adds overhead to CI. Rather than adding more cruft, since the old region/coordinate visualizations will be removed in 8.0, use a single test suite, but configure it differently between 7.x and master.

  • 7.x: run test suite with flag on. This is the mainline where the old-visualizations can still be used. test-coverage makes sense.
  • master (8.0): turn flag off. The old visualizations will be removed here anyway. There is no need for test-coverage

There is ongoing PR to turn the flag to true by default: https://github.com/elastic/kibana/pull/94968/files. Let this merge first. After, I can create new PR that turns this flag to false, and disable the associated tests.

cc @stratoula

@nreese
Copy link
Contributor

nreese commented Dec 15, 2021

Closing, showMapVisualizationTypes removed in 8.0

@nreese nreese closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation test v7.16.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

3 participants