Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Design polish: Waterfall view suggested visual improvements #90777

Closed
formgeist opened this issue Feb 9, 2021 · 2 comments
Closed
Labels
polish Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@formgeist
Copy link
Contributor

formgeist commented Feb 9, 2021

Summary

I've put together a list of suggested small visual enhancements to tidy up the experience of the Waterfall visualization.

Change the size of the tooltip to accommodate for longer URLs #90909

I reckon it might be good to allow the tooltip of the URL to be able to read the full URL without too many breaks.

Decision

After presenting to the team, we decided that we need to set a min-width of the tooltip to accommodate URLs. Word-break is still going to happen for long URLs.

Screenshot 2021-02-09 at 14 38 30

Change the delay of the tooltip #90909

We can change the delay of the tooltip showing up by adding the delay="long" prop.

Kapture 2021-02-09 at 14 40 39

Decrease the font-size of the URL/span name list to afford more chars per item #90913

We can decrease the font-size by 2px to accommodate more characters in the list and thereby providing more context without losing the legibility.

Decision

After presenting it to the team, we decided to do more to condense the waterfall rows which means looking at defining a new height for the bars and the row container as well as decreasing the font size of the URL label.

Screenshot 2021-02-09 at 14 38 24

History table list: Fix the image size and avoid the rows jumping because of different sizes when they load in #90914

Kapture 2021-02-09 at 14 34 00

Additionally, the row size is different when there's an image and when there's no image available.

Decision

After presenting to the team, we decided to at least set a fixed height on the image so that even if the viewport size is different the rows will always be the same because the image is constrained.

Screenshot 2021-02-09 at 14 34 49

History table list: Decrease the spinner size in the table row for images #90914

Screenshot 2021-02-09 at 14 33 16

I reckon we can get away with only having a size="m" in the row. Additionally, it would be nice if the spinner would be centered within the image container, whether an image will load or not.

@formgeist formgeist added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability polish labels Feb 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@formgeist
Copy link
Contributor Author

@paulb-elastic The enhancement issues are ready and available (#90909, #90913, and #90914). Feel free to prioritize as it fits in. Closing this issue as we now have individual issues for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

No branches or pull requests

2 participants