Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Component #9143

Closed
4 of 7 tasks
cjcenizal opened this issue Nov 18, 2016 · 9 comments
Closed
4 of 7 tasks

Table Component #9143

cjcenizal opened this issue Nov 18, 2016 · 9 comments
Labels
Meta Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Nov 18, 2016

Background

We need a component for consistently displaying tabular data, with functionality for:

  • Searching and filtering the rows
  • Selecting multiple rows and applying batch actions
  • Switching out of table view into a grid view (where applicable)
  • Selecting a row to dive into deeper detail

Steps

  • Test out design in different use cases, with wireframes. See if it works with existing content. Just rough stress tests. Start with Monitoring.
  • Implement it as a component in UI framework.
  • Integrate in Kibana, find edge cases we may have overlooked.

Integration points

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Meta labels Nov 18, 2016
@thomasneirynck
Copy link
Contributor

FYI: we've been using the :Data Table label in visualization.

https://github.com/elastic/kibana/issues?utf8=%E2%9C%93&q=is%3Aopen%20is%3Aissue%20label%3A%22%3AData%20Table%22

It's not exhaustive (I'm sure we mist some here&there), but it should give us a sense of what people are looking for.

@uboness
Copy link

uboness commented Nov 18, 2016

Is it really the same? The Data Table here is not a visualization (which to me looks like the label refers to the Data Table Visualization). Here we refer to the Kibana table component that is used in the various pages to display list of items in a table (e.g. the table showing all Dashboards in "Management > Kibana >Saved Objects > Dashboards")

@cjcenizal I think we should change the name here and not call it "Data Table" (I can see how "Data Table" better describes the visualization). Maybe we can name this one "Items Table"?

@cjcenizal
Copy link
Contributor Author

Why not just call it "Table"?

@uboness
Copy link

uboness commented Nov 18, 2016

WOW... "Table"... how did you come up with it??????!!!!!!

@cjcenizal cjcenizal changed the title DataTable Component Table Component Nov 18, 2016
@Bargs
Copy link
Contributor

Bargs commented Nov 21, 2016

Table? Why not frames?

@cjcenizal
Copy link
Contributor Author

@Bargs Do you have an example of this name being used for tables somewhere else? When I hear "frames" the first thing I think of is something like an iframe, a window into some other content, not a table.

@Bargs
Copy link
Contributor

Bargs commented Nov 21, 2016

Sorry, I was just making a 90s web development joke :)

@cjcenizal
Copy link
Contributor Author

Haha my bad! That one went right over my head.

@cjcenizal
Copy link
Contributor Author

For the most part this has been addressed by #9462. We need more specific issues for instances in the UI where we should update it with the new Table component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

4 participants