Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for elasticsearch.sniff* config #91640

Closed
mshustov opened this issue Feb 17, 2021 · 2 comments
Closed

Add integration tests for elasticsearch.sniff* config #91640

mshustov opened this issue Feb 17, 2021 · 2 comments
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

Setting elasticsearch.sniff* in the config file used to cause authentication problems #42224
The root problem has been fixed in #91276
We should add integration tests to make sure that code changes do not break cases when users configure elasticsearch.sniff* settings.

@mshustov mshustov added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Feb 17, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet
Copy link
Contributor

Even if it would make sense to add such integration tests, we now have unit tests asserting that the generated client configuration is on the expected shape to avoid this issue (auth info at the top level of the config and not per node), and implementing those tests, in addition to mostly testing the behavior of the ES client, is not trivial, as the exact behavior of the sniff/sniff on start logic is an implementation detail of the client.

For those reasons, I will close this.

@pgayvallet pgayvallet closed this as not planned Won't fix, can't repro, duplicate, stale Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

3 participants