Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Exit Edit Mode on Save As #92085

Closed
3 tasks done
ThomThomson opened this issue Feb 19, 2021 · 1 comment · Fixed by #97941
Closed
3 tasks done

[Dashboard] Exit Edit Mode on Save As #92085

ThomThomson opened this issue Feb 19, 2021 · 1 comment · Fixed by #97941
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Feb 19, 2021 •
edited
Loading

Kibana version: 7.12

Describe the bug:
When the user saves a dashboard through the save as button on the top nav, the user is kicked out of Edit mode.

Steps to reproduce:

  1. Load an existing dashboard
  2. Save as, retaining the existing name
  3. Notice that you are now in view mode

Expected behavior:
The dashboard should remain in edit mode when saving in the following situations:

  • Save as (Retain existing name)
  • Save as (Rename)
  • Save as (Save as New / Redirect)
@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features labels Feb 19, 2021
@ThomThomson ThomThomson added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Feb 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson changed the title [Dashboard] Exits Edit Mode on Save As [Dashboard] Exit Edit Mode on Save As Feb 19, 2021
@ThomThomson ThomThomson mentioned this issue Feb 19, 2021
Merged
2 tasks
@kmartastic kmartastic added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Mar 2, 2021
@ThomThomson ThomThomson mentioned this issue Apr 30, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard] Rebuild State Management ThomThomson/kibana
3 participants
@ThomThomson @elasticmachine @kmartastic