Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Rename "reset layer" in single layer visualizations #93412

Closed
flash1293 opened this issue Mar 3, 2021 · 5 comments · Fixed by #94539
Closed

[Lens] Rename "reset layer" in single layer visualizations #93412

flash1293 opened this issue Mar 3, 2021 · 5 comments · Fixed by #94539
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Right now there's a "reset layer" button for each layer:
Screenshot 2021-03-03 at 13 44 13

However, this button is also shown for non-layer-based visualizations like table or pie:
Screenshot 2021-03-03 at 13 44 20

This seems like a weird way of phrasing the button because the layer concept doesn't really apply in this case.

In this case it should get renamed to "Reset visualization"

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra
Copy link
Contributor

mbondyra commented Mar 3, 2021

@flash1293, just to make this clear:

  1. For pie, datatable, metric or any other allowing only one layer visualization, we should display reset visualization
  2. For xy chart (visualization allowing more than one layer) when only one layer exists, we should display reset layer
  3. For xy chart (visualization allowing more than one layer) when more than one layer exist, we should display delete layer

Is this correct?

@flash1293
Copy link
Contributor Author

@mbondyra Yes, exactly

@anish-khanna
Copy link
Contributor

If nobody has tried to clean up this issue, I'd like to do so!

@flash1293
Copy link
Contributor Author

@anish-khanna Sure, thanks for participating! I'll assign the issue to you, let me know if you can't work on it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants