Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved objects management table doesn't adhere to the listing limit set in advanced settings #93505

Closed
bhavyarm opened this issue Mar 3, 2021 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Saved Objects Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Mar 3, 2021

Kibana version: 7.12.0

Elasticsearch version: 7.12.0

Server OS version: darwin

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If user sets the listing objects limit in advanced settings using "Objects listing limit" - it doesn't reflect in saved objects management table.

Dashboard and visualize work fine.

Steps to reproduce:

  1. Set the Objects listing limit in advanced settings as 2
  2. Install all the three sample data
  3. Go to visualize/dashboard - the listing table displays 2 objects
  4. Go to saved objects all of them get displayed

Screenshots (if relevant):
Advanced settings:
Screen Shot 2021-03-03 at 1 46 04 PM

Dashboards:
Screen Shot 2021-03-03 at 1 46 11 PM

Saved objects:
Screen Shot 2021-03-03 at 1 46 20 PM

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects labels Mar 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 4, 2021
@pgayvallet
Copy link
Contributor

Given that the SOM page is an administration page, I'm not sure applying this setting here would really make sense.

I even think it could be potentially dangerous, e.g because of the listingLimit, we're only displaying, say, 5 of 10 dashboards in the table, but then when the customer performs an export by type selecting dashboard, the export will include all 10 of them.

Also, to be honest, I think the initial intent of this setting was to avoid fetching too many objects from the server to the client in a single request, which may be what pages like the dashboard listing page was doing, with a full in-memory load of all the items in their listing table (or is still, I didn't check), but for the SOM page, we're performing one request per page of the table, effectively never loading more than 100 objects at one.

What do the other members think about this?

@lukeelmers
Copy link
Member

I think the initial intent of this setting was to avoid fetching too many objects from the server to the client in a single request

Yeah, I tend to agree that it doesn't make a lot of sense to apply this setting to the SO listing page, however I do understand that it's a little confusing from a UX perspective to see more objects than are indicated in the setting, especially when other parts of Kibana adhere to it.

If we did want to apply it to SO listing, we would need to explain the caveats in a big warning at the top similar to what Dashboards have. But at that point, are we really improving the UX, or just making things more confusing? 🙂

This feels like something that @elastic/shared-ux would care about too -- historically we have not applied this setting consistently everywhere.

@afharo afharo added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Jul 19, 2022
@pgayvallet
Copy link
Contributor

Closing as working as expected - we're just rightfuly not using this setting in the SOM page

@pgayvallet pgayvallet closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Saved Objects Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
Status: Done (7.13)
Development

No branches or pull requests

6 participants