Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Add test to ensure all stack alerts are part of stack alert feature privilege. #95242

Closed
ymao1 opened this issue Mar 23, 2021 · 2 comments · Fixed by #98195
Closed
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@ymao1
Copy link
Contributor

ymao1 commented Mar 23, 2021

When adding this new stack alert, we forgot to add the alert type id to the stack alerts feature privilege so users with only access to stack alerts would not be able to see this stack alert. We should find a way to ensure this doesn't happen again in the future, maybe with some tests that make sure all available stack alerts are part of the stack alerts feature privilege?

@ymao1 ymao1 added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

Relates (or duplicate?) to #88770. It seems like one option may be to have the test suite (or each test) use the smallest amount of privileges to run successfully.

@mikecote mikecote added the technical debt Improvement of the software architecture and operational architecture label Mar 30, 2021
@ymao1 ymao1 self-assigned this Apr 23, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants