Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable] Reduce page load bundle to under 100kB #95860

Closed
tylersmalley opened this issue Mar 30, 2021 · 4 comments · Fixed by #113126
Closed

[embeddable] Reduce page load bundle to under 100kB #95860

tylersmalley opened this issue Mar 30, 2021 · 4 comments · Fixed by #113126
Labels
Feature:Embedding Embedding content via iFrame impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort performance

Comments

@tylersmalley
Copy link
Contributor

tylersmalley commented Mar 30, 2021 •
edited
Loading

For details, refer to the meta issue at #95853

The embeddable plugin is currently 183,325 bytes. To consider this issue closed, the limits.yml should be updated with the value under 100000.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tylersmalley tylersmalley changed the title [embeddable] Reduce page load bundle to under 100k [embeddable] Reduce page load bundle to under 100kb Mar 30, 2021
@tylersmalley tylersmalley changed the title [embeddable] Reduce page load bundle to under 100kb [embeddable] Reduce page load bundle to under 100kB Mar 30, 2021
@streamich streamich added Feature:Embedding Embedding content via iFrame impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort performance labels May 4, 2021
@tylersmalley
Copy link
Contributor Author

Currently, 200,887 bytes - trending in the wrong direction. Can someone confirm this has been prioritized?

@tylersmalley
Copy link
Contributor Author

Currently 187,404 bytes. Can someone confirm what work here is planned?

@Dosant
Copy link
Contributor

Dosant commented Sep 21, 2021

Test samples stand out here (30Kb)

Screen Shot 2021-09-21 at 11 34 25

I think we should try to get rid of them. I think we export them so they can be used in example plugins. Maybe we should move to an example plugin?

Other significant improvements are around all the uiActions, I think those should be considered and addressed by #65993

This was referenced Sep 22, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[embeddable] Don’t include test samples into initial bundle Dosant/kibana
4 participants
@tylersmalley @Dosant @streamich @elasticmachine