Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kibanaUtils] Reduce page load bundle to under 100kB #95866

Closed
tylersmalley opened this issue Mar 30, 2021 · 4 comments
Closed

[kibanaUtils] Reduce page load bundle to under 100kB #95866

tylersmalley opened this issue Mar 30, 2021 · 4 comments
Labels
Feature:Plugins impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort performance

Comments

@tylersmalley
Copy link
Contributor

For details, refer to the meta issue at #95853

The kibanaUtils plugin is currently 146,560 bytes. To consider this issue closed, the limits.yml should be updated with the value under 100000.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tylersmalley tylersmalley changed the title [kibanaUtils] Reduce page load bundle to under 100k [kibanaUtils] Reduce page load bundle to under 100kb Mar 30, 2021
@tylersmalley tylersmalley changed the title [kibanaUtils] Reduce page load bundle to under 100kb [kibanaUtils] Reduce page load bundle to under 100kB Mar 30, 2021
@streamich streamich added Feature:New Feature New feature not correlating to an existing feature label impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort labels May 4, 2021
@streamich
Copy link
Contributor

This needs discussion on how to approach it. App Services team is the main maintainer of the kibana_utils plugin, but not all code there is directly maintained by us. It is like a kitchen sink for utility code.

Possible solutions would be:

  • We create "utils" plugins for each team separately, in their domain, e.g. kibana_app/utils.
  • Or we allow deep imports from kibana_util plugin, so that other teams can only import what they need (but that would not work with our current .js bundling way, where each plugin is its own whole bundle).

@streamich streamich added Feature:Plugins performance and removed Feature:New Feature New feature not correlating to an existing feature label labels May 4, 2021
@tylersmalley
Copy link
Contributor Author

@streamich, I think a package would be a much more appropriate place for utilities and would delegate bundle size to the consumer. A plugin that is just a dumping ground for shared utilities is the issue. We shouldn't be loading all these utilities on every page load.

@Dosant
Copy link
Contributor

Dosant commented Oct 14, 2021

KibanaUtils are under 100Kb, closing this one 🎉 and opened an issue for further improvements: #114988

@Dosant Dosant closed this as completed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Plugins impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort performance
Projects
None yet
Development

No branches or pull requests

4 participants