Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core deprecations service] Require manual corrective steps for config deprecations #96059

Closed
alisonelizabeth opened this issue Apr 1, 2021 · 3 comments · Fixed by #100997
Closed
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented Apr 1, 2021

The new deprecations service provided by core (#94845) currently doesn't require config deprecations to provide manual corrective steps. This leads to a poor UX, as a user doesn't have context on how to resolve a deprecation. It also is an inconsistent experience as some config deprecations provide manual corrective steps, while others do not.

This issue is to enforce all config deprecations to register manual corrective steps and throw an error if none are provided.

Note: The existing config deprecations will need to be updated before this can be enforced.

@alisonelizabeth alisonelizabeth added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result Feature:Upgrade Assistant labels Apr 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@joshdover
Copy link
Contributor

The first step to this should be auditing all existing deprecations and creating a checklist for teams to address this. #83910 is a good example of how we can coordinate this.

@pgayvallet
Copy link
Contributor

Note that all config deprecations relying on the provided rename and unused factories are declaring manual corrective steps, as these factories are defining them. So only the 'custom' config deprecations are concerned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants