Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps embeddable to respect containers' auto-refresh #96550

Closed
Dosant opened this issue Apr 8, 2021 · 1 comment · Fixed by #97298
Closed

Maps embeddable to respect containers' auto-refresh #96550

Dosant opened this issue Apr 8, 2021 · 1 comment · Fixed by #97298
Assignees
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0 v8.0.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Apr 8, 2021

Recently we did some improvements to how auto-refresh works in Dashboard and maps embeddable should be tweaked a bit to follow a general pattern and to fix some edge cases.

What has changed in Dashboard?

  1. Dashboard container handles auto-refresh. Individual panels should not track auto-refresh anymore. This was done to synchronize dashboards' search session creation and all searches emitted from embeddable. [Search] Search Sessions with relative time range  #84405
  2. As an improvement, we trigger a new auto-refresh loop only when all searches are completed and the dashboard container takes care of it Don't trigger auto-refresh until previous refresh completes  #93410

The problem with map embeddable is that currently, it has its own auto-refresh loop:

this._refreshTimerId = window.setInterval(() => {

That loop is not synchronized with the dashboards' search sessions and causes bugs, for example, "start a new loop when the request completes" isn't respected. This breaks the dashboard's auto-refresh when aggressive refresh intervals are used.

To consider this fixed:

  • Map embeddable shouldn't have any internal interval to handle auto-refresh
  • Instead it should just trigger reload whenever embeddable's input.searchSessionId changes

cc @nreese since you've already fixed some bugs in maps embeddable around search sessions

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Apr 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants