Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Add vector drawing & persisting functionality to Maps app #96836

Closed
6 of 9 tasks
kindsun opened this issue Apr 12, 2021 · 4 comments
Closed
6 of 9 tasks

[Maps] Add vector drawing & persisting functionality to Maps app #96836

kindsun opened this issue Apr 12, 2021 · 4 comments
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Meta

Comments

@kindsun
Copy link
Contributor

kindsun commented Apr 12, 2021

Following the prototype POC #96365 and to resolve #41469, this issue describes the requirements and steps needed to add vector drawing capability to the Maps app.

This feature should include the following capabilties:

  • Draw standard shapes including point, linestring, polygon, bounding box, and circle
  • Save drawn shapes to a new or existing Elasticsearch index
  • Remove and edit data, minimally including current or previously drawn data, maximally including data indexed by other means
  • Launch draw tools both as a means to create a new layer and as an edit tool on existing document layers

This feature will be broken down into the following steps which will likely grow and change as we move forward. Several of these features will be broken out of the existing POC:

cc @kmartastic @thomasneirynck

@kindsun kindsun added Meta [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Apr 12, 2021
@kindsun kindsun self-assigned this Apr 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun
Copy link
Contributor Author

kindsun commented May 3, 2021

Open questions about overall flow for design and Maps team:

  • Can we confirm we like the draw toolbar as a home for feature editing? Does the toolbar make sense in its current location as done in the POC?
  • Should there be a confirmation step when each feature is updated? More broadly, what should the feature add/edit flow look like?
  • How should this merge with the filter capability? Should we try to differentiate this from filter capability? (different colors, other?)
  • Does the current method of picking index patterns via pop-up (same as filters) make sense?
  • How should editing feature attributes work? Should this be a feature-by-feature pop-up? If features are added to an existing index, can they select which attributes to update? Do they have to do this for each feature?

@kmartastic
Copy link
Contributor

kmartastic commented May 5, 2021

Path forward:

New Layer Flow
-Add Layer > Create Index
-Automatically start editing > Show toolbar with appropriate controls

Edit Existing Layer Flow
-Map has editable layers
-Click Tools > Edit layer by selecting appropriate index + layer combination
-Show toolbar with appropriate controls

Questions:

  1. Do we need a commit per new document? per editing session?
  2. Can we support automatic inclusion of attributes for new blank layer? what about existing layer?

@aaronjcaldwell @miukimiu @nreese @thomasneirynck anything missing?

@thomasneirynck
Copy link
Contributor

Closed with #41469

Can follow up on outstanding items as they come up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Meta
Projects
None yet
Development

No branches or pull requests

4 participants