Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve navbar extension #9860

Closed
scampi opened this issue Jan 13, 2017 · 2 comments · Fixed by #9871
Closed

improve navbar extension #9860

scampi opened this issue Jan 13, 2017 · 2 comments · Fixed by #9871
Labels
dev enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@scampi
Copy link
Contributor

scampi commented Jan 13, 2017

  • use $location for knowing on which page the button should be on Sorry there is no need for this, I didn't realize I could inject services when registering the extension
  • It would be good if it is possible to pass a controller from the navbar extension. It is then possible to have angular expressions in the template of the extension. The template's content would be dependent on external factors, e.g., the current page being browsed.
@epixa
Copy link
Contributor

epixa commented Jan 17, 2017

Can you elaborate on what you'd like to see here, what the use case is, etc?

@scampi
Copy link
Contributor Author

scampi commented Jan 18, 2017

@epixa I updated the description.

@epixa epixa added dev release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed feedback_needed labels Jan 19, 2017
@epixa epixa added enhancement New value added to drive a business result and removed release_note:enhancement labels May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants