Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance saved objects migrations collect failing docs implementation #99685

Closed
4 tasks done
TinaHeiligers opened this issue May 10, 2021 · 2 comments · Fixed by #100297
Closed
4 tasks done

Enhance saved objects migrations collect failing docs implementation #99685

TinaHeiligers opened this issue May 10, 2021 · 2 comments · Fixed by #100297
Labels
enhancement New value added to drive a business result Feature:Saved Objects project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented May 10, 2021 •
edited
Loading

In #96986 we continue trying to transform all documents and collect any failures rather than failing the migration at the first error thrown.

This issue is to track follow ups to the original PR:

  • TransformSavedObjectDocumentError shows the problematic SO, and the source of the original problem. we can make that more explicit.
    • Use the originalError's message as the top level message rather than constructing one.
  • Refactor extractTransformFailuresReason to construct the full, final migration failure reason.
    Integration test improvements:
  • Use a 7.x index to test the changes introduced to REINDEX_SOURCE_TO_TEMP_*.
  • Ensure we get all the failed document ids in the logs along with the full failure reason
@TinaHeiligers TinaHeiligers added enhancement New value added to drive a business result Feature:Saved Objects project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient labels May 10, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label May 10, 2021
@TinaHeiligers TinaHeiligers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label May 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 10, 2021
@mshustov
Copy link
Contributor

@TinaHeiligers should we add it to #75780 ?

This was referenced May 11, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Saved Objects project:ResilientSavedObjectMigrations Reduce Kibana upgrade failures by making saved object migrations more resilient Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SO migrations: Improves transformation error creation and testing TinaHeiligers/kibana
3 participants
@mshustov @TinaHeiligers @elasticmachine