[Search] Search Sessions Monitoring Task #85253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save IDs only in monitoring loop
…o sessions/retry-logic
…o sessions/monitor-task
lizozom
requested review from
Dosant and
lukasolson
and removed request for
a team
|
Code lgtm, tested following things:
I took a sample dashboard and added a single slow viz with 60s shard delay agg. I expected to see in dev tools session completed in around 60s and it was the case once. Session also errored out as the result. |
lukasolson
reviewed
Jan 7, 2021
x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.ts
Outdated
Show resolved
Hide resolved
lukasolson
approved these changes
Jan 7, 2021
added 2 commits
January 7, 2021 22:52
|
This seems like additional features targeted after 7.11.0 FF? 28 files changed (I didn't look but I'm sure some are tests) seems like a change we wouldn't put in after feature freeze. |
tsullivan
reviewed
Jan 7, 2021
x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.ts
Outdated
Show resolved
Hide resolved
|
@Dosant what you saw is the fact that the |
Dosant
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Didn't re-test since the last review considering #85253 (comment) is expected
gmmorris
reviewed
Jan 11, 2021
gmmorris
reviewed
Jan 11, 2021
gmmorris
approved these changes
Jan 11, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
lizozom
added a commit
to lizozom/kibana
that referenced
this pull request
Jan 11, 2021
* Monitor ids * import fix * solve circular dep * eslint * mock circular dep * max retries test * mock circular dep * test * jest <(-:C * jestttttt * [data.search] Move search method inside session service and add tests * merge * Move background session service to data_enhanced plugin * Better logs Save IDs only in monitoring loop * Fix types * Space aware session service * ts * initial * initial * Fix session service saving * merge fix * stable stringify * INMEM_MAX_SESSIONS * INMEM_MAX_SESSIONS * use the status API * Move task scheduling behind a feature flag * Update x-pack/plugins/data_enhanced/server/search/session/session_service.ts Co-authored-by: Anton Dosov <dosantappdev@gmail.com> * Add unit tests * Update x-pack/plugins/data_enhanced/server/search/session/session_service.ts Co-authored-by: Anton Dosov <dosantappdev@gmail.com> * Use setTimeout to schedule monitoring steps * Update request_utils.ts * settimeout * tiny cleanup * Core review + use client.asyncSearch.status * update ts * fix unit test * code review fixes * Save individual search errors on SO * Don't re-fetch completed or errored searches * Rename Background Sessions to Search Sessions (with a send to background action) * doc * doc * jest fun * rename rfc * translations * merge fix * merge fix * code review * update so name in features * Move deleteTaskIfItExists to task manager * task_manager to ts project * Move deleteTaskIfItExists to public contract * mock * use task store * ts * code review * code review + jest * Alerting code review Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <dosantappdev@gmail.com> Co-authored-by: restrry <restrry@gmail.com>
lizozom
added a commit
that referenced
this pull request
Jan 11, 2021
* Monitor ids * import fix * solve circular dep * eslint * mock circular dep * max retries test * mock circular dep * test * jest <(-:C * jestttttt * [data.search] Move search method inside session service and add tests * merge * Move background session service to data_enhanced plugin * Better logs Save IDs only in monitoring loop * Fix types * Space aware session service * ts * initial * initial * Fix session service saving * merge fix * stable stringify * INMEM_MAX_SESSIONS * INMEM_MAX_SESSIONS * use the status API * Move task scheduling behind a feature flag * Update x-pack/plugins/data_enhanced/server/search/session/session_service.ts Co-authored-by: Anton Dosov <dosantappdev@gmail.com> * Add unit tests * Update x-pack/plugins/data_enhanced/server/search/session/session_service.ts Co-authored-by: Anton Dosov <dosantappdev@gmail.com> * Use setTimeout to schedule monitoring steps * Update request_utils.ts * settimeout * tiny cleanup * Core review + use client.asyncSearch.status * update ts * fix unit test * code review fixes * Save individual search errors on SO * Don't re-fetch completed or errored searches * Rename Background Sessions to Search Sessions (with a send to background action) * doc * doc * jest fun * rename rfc * translations * merge fix * merge fix * code review * update so name in features * Move deleteTaskIfItExists to task manager * task_manager to ts project * Move deleteTaskIfItExists to public contract * mock * use task store * ts * code review * code review + jest * Alerting code review Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <dosantappdev@gmail.com> Co-authored-by: restrry <restrry@gmail.com> Co-authored-by: Lukas Olson <olson.lukas@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Anton Dosov <dosantappdev@gmail.com> Co-authored-by: restrry <restrry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contains #85253 (will be rebased on top)
This PR implements the Search Sessions monitoring task, as specified in the Search Sessions (formerly known as Background Sessions RFC).
The
Search Sessionservice is responsible for tracking sessions in memory and storing them, if the user chooses to do so, but after sessions are saved, the responsibility for tracking them is passed down to the monitoring task.This task is responsible for checking up on
in_progresssearch sessions, fetching the status of each search request and updating the search session's status (so it's correctly reflected in the Management UI for example).Once available, this task would probably also be integrated with the push notification service, to provide more immediate completion notifications to the user.
Checklist
Delete any items that are not applicable to this PR.
For maintainers