Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent exit on pipelines reloading #10345

Closed
colinsurprenant opened this issue Jan 23, 2019 · 0 comments · Fixed by #10346
Closed

silent exit on pipelines reloading #10345

colinsurprenant opened this issue Jan 23, 2019 · 0 comments · Fixed by #10346
Labels

Comments

@colinsurprenant
Copy link
Contributor

under these conditions:

  • pipeline reloading disabled
  • using a system pipeline like the monitoring pipeline
  • very long pipeline startup time due to the pipeline configuration complexity

logstash may silently exit when issued a SIGHUP to signal pipelines reloading.

This can be trivially reproduced by setting the sleep to 0.1 in:

while !Stud.stop?
if clean_state? || running_user_defined_pipelines?
sleep(0.5)
else
break
end

And simulating a slow reload time by forcing a 5 seconds sleep on pipeline reloading in just before the Create.new:

if stop_result.successful?
Create.new(@pipeline_config, @metric).execute(agent, pipelines)
else

Using any dummy pipeline configured in pipelines.yml, disabling pipeline reloading and enabling monitoring when issuing a SIGHUP, logstash will silently terminate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant