Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify if a PipelineState could hold a nil pipeline #10405

Open
colinsurprenant opened this issue Feb 6, 2019 · 0 comments
Open

verify if a PipelineState could hold a nil pipeline #10405

colinsurprenant opened this issue Feb 6, 2019 · 0 comments

Comments

@colinsurprenant
Copy link
Contributor

This is a followup of issue #10346 review comment #10346 (comment)

There is currently a check for a nil pipeline condition such as

pipelines = @agent.running_user_defined_pipelines
pipelines.each do |_, pipeline|
unless pipeline.nil?
pipeline.collect_dlq_stats
end
end

This check should not be necessary but a more thorough review should be done to make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant