Use transaction root attribute name (#71)

Author: lahsivjar

enrichments/trace/config/config.go

@@ -33,7 +33,7 @@ type ResourceConfig struct {
 // ElasticTransactionConfig configures the enrichment attributes for the
 // spans which are identified as elastic transaction.
 type ElasticTransactionConfig struct {
-	TraceRoot    AttributeConfig `mapstructure:"trace_root"`
+	Root         AttributeConfig `mapstructure:"root"`
 	Name         AttributeConfig `mapstructure:"name"`
 	Type         AttributeConfig `mapstructure:"type"`
 	Result       AttributeConfig `mapstructure:"result"`
@@ -61,7 +61,7 @@ func Enabled() Config {
 			AgentVersion: AttributeConfig{Enabled: true},
 		},
 		Transaction: ElasticTransactionConfig{
-			TraceRoot:    AttributeConfig{Enabled: true},
+			Root:         AttributeConfig{Enabled: true},
 			Name:         AttributeConfig{Enabled: true},
 			Type:         AttributeConfig{Enabled: true},
 			Result:       AttributeConfig{Enabled: true},

enrichments/trace/internal/elastic/attributes.go

@@ -23,7 +23,7 @@ const (
 	AttributeAgentVersion = "agent.version"
 
 	// span attributes
-	AttributeTraceRoot         = "trace.root"
+	AttributeTransactionRoot   = "transaction.root"
 	AttributeTransactionName   = "transaction.name"
 	AttributeTransactionType   = "transaction.type"
 	AttributeTransactionResult = "transaction.result"

enrichments/trace/internal/elastic/span.go

@@ -161,8 +161,8 @@ func (s *spanEnrichmentContext) enrichTransaction(
 	span ptrace.Span,
 	cfg config.ElasticTransactionConfig,
 ) {
-	if cfg.TraceRoot.Enabled {
-		span.Attributes().PutBool(AttributeTraceRoot, isTraceRoot(span))
+	if cfg.Root.Enabled {
+		span.Attributes().PutBool(AttributeTransactionRoot, isTraceRoot(span))
 	}
 	if cfg.Name.Enabled {
 		span.Attributes().PutStr(AttributeTransactionName, span.Name())

enrichments/trace/internal/elastic/span_test.go

@@ -43,7 +43,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			input:  ptrace.NewSpan(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "",
 				AttributeEventOutcome:      "success",
 				AttributeTransactionResult: "Success",
@@ -65,7 +65,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			}(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "testtxn",
 				AttributeEventOutcome:      "success",
 				AttributeTransactionResult: "HTTP 2xx",
@@ -87,7 +87,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			}(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "testtxn",
 				AttributeEventOutcome:      "success",
 				AttributeTransactionResult: "HTTP 1xx",
@@ -108,7 +108,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			}(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "testtxn",
 				AttributeEventOutcome:      "success",
 				AttributeTransactionResult: "HTTP 5xx",
@@ -130,7 +130,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			}(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "testtxn",
 				AttributeEventOutcome:      "success",
 				AttributeTransactionResult: "OK",
@@ -152,7 +152,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			}(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "testtxn",
 				AttributeEventOutcome:      "success",
 				AttributeTransactionResult: "Internal",
@@ -169,7 +169,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			}(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "testtxn",
 				AttributeEventOutcome:      "success",
 				AttributeTransactionResult: "Success",
@@ -186,7 +186,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			}(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "testtxn",
 				AttributeEventOutcome:      "failure",
 				AttributeTransactionResult: "Error",
@@ -203,7 +203,7 @@ func TestElasticTransactionEnrich(t *testing.T) {
 			}(),
 			config: config.Enabled().Transaction,
 			enrichedAttrs: map[string]any{
-				AttributeTraceRoot:         true,
+				AttributeTransactionRoot:   true,
 				AttributeTransactionName:   "testtxn",
 				AttributeEventOutcome:      "success",
 				AttributeTransactionResult: "Success",