Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay support for os specific packages #533

Closed
ruflin opened this issue Jun 22, 2020 · 6 comments
Closed

Delay support for os specific packages #533

ruflin opened this issue Jun 22, 2020 · 6 comments
Assignees
Labels
Ingest Management:beta1 Group issues for ingest management beta1

Comments

@ruflin
Copy link
Member

ruflin commented Jun 22, 2020

In the future, we plan to support OS specific configurations options like paths per os. An example can be found here: https://github.com/elastic/package-storage/blob/c3db4fa7148841ace67639a82a27d62ab257b1f8/packages/mysql/0.1.0/dataset/error/manifest.yml#L16

We don't support it today and it will not be supported in 7.9. Even though we already came up with a suggested format on how it should look like, I suggest we remove it from all existing packages for now so moving forward we keep the flexibility to implement it the way it is best, meaning it will be an addition only and prevent any breaking change.

Also on the registry side we don't validate it at the moment but as soon as we support it, we should.

@ruflin ruflin added the Ingest Management:beta1 Group issues for ingest management beta1 label Jun 22, 2020
@ruflin
Copy link
Member Author

ruflin commented Jun 22, 2020

@jen-huang FYI
@mtojek I think this has mostly an effect on the package generator?

@mtojek
Copy link
Contributor

mtojek commented Jun 23, 2020

I think it supported it at some point, but wouldn't focus much on it, as there is no decision yet what to do with the generator. You can open an issue for integrations if it becomes an problem.

@jen-huang
Copy link
Contributor

Noted. Removal won't affect Kibana side.

@ruflin
Copy link
Member Author

ruflin commented Jun 24, 2020

@mtojek I filed elastic/integrations#108

@ruflin
Copy link
Member Author

ruflin commented Jun 24, 2020

Here is a follow up issue to rethink it in the future: #548

ruflin added a commit to ruflin/package-registry that referenced this issue Jun 24, 2020
As discussed in elastic#533 the os specific configs should be removed from now.
ruflin added a commit that referenced this issue Jun 29, 2020
As discussed in #533 the os specific configs should be removed from now.
@ruflin
Copy link
Member Author

ruflin commented Jul 2, 2020

Closing as all related changes were implemented.

@ruflin ruflin closed this as completed Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:beta1 Group issues for ingest management beta1
Projects
None yet
Development

No branches or pull requests

3 participants