Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverless project resources #817

Merged
merged 19 commits into from
Aug 26, 2024
Merged

Add serverless project resources #817

merged 19 commits into from
Aug 26, 2024

Conversation

tobio
Copy link
Member

@tobio tobio commented Jun 3, 2024

Description

Currently only includes elasticsearch_project resources. IMO we should include at least all project types, also likely worthwhile including a serverless_region data source, and maybe project data sources since they should be simple to add re-using the resource read code.

This PR also include the terraform code generators, currently configured to generate the serverless resource schema and openapi client.

How Has This Been Tested?

Manually, acceptance tests. I need to add some more unit tests here.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

I need to add more tests and docs here.

@tobio tobio self-assigned this Jun 3, 2024
@tobio tobio force-pushed the serverless branch 2 times, most recently from b0b4990 to 3aedc9b Compare June 27, 2024 08:06
@tobio tobio marked this pull request as ready for review July 12, 2024 11:00
@tobio tobio requested a review from a team as a code owner July 12, 2024 11:00
@dimuon
Copy link
Contributor

dimuon commented Jul 16, 2024

@tobio , make gen adds the license header to a bunch of files.

@@ -0,0 +1,688 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to document updating serveless OpenAPI specs and mention where to look for the updated spec.json?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, my bad, I mean where to look for the updated serverless-project-api-dereferenced.yml.

@dimuon
Copy link
Contributor

dimuon commented Jul 17, 2024

@tobio , I completed the review (though I skim through security_test.go and observability_test.go which look similar to elasticsearch_test.go)

@tobio tobio requested a review from dimuon August 6, 2024 11:41
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@tobio tobio merged commit 2d22248 into elastic:master Aug 26, 2024
3 checks passed
@tobio tobio deleted the serverless branch August 26, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants