-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serverless project resources #817
Conversation
b0b4990
to
3aedc9b
Compare
@tobio , |
@@ -0,0 +1,688 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to document updating serveless OpenAPI specs and mention where to look for the updated spec.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, my bad, I mean where to look for the updated serverless-project-api-dereferenced.yml
.
@tobio , I completed the review (though I skim through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Description
Currently only includes elasticsearch_project resources. IMO we should include at least all project types, alsolikely worthwhile including a serverless_region data source, and maybe project data sources since they should be simple to add re-using the resource read code.This PR also include the terraform code generators, currently configured to generate the serverless resource schema and openapi client.
How Has This Been Tested?
Manually, acceptance tests. I need to add some more unit tests here.
Types of Changes
Readiness Checklist
I need to add more tests and docs here.