Bugfix: node-types-validation should handle empty stack version. #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the version is unset, the validation crashes with an error. This can happen in certain scenarios: When using a reference (e.g. `data.ec_stack.latest.version`) it will not be resolved in a first phase when this validation is called. In such cases the validation should be skipped. The validation still works as it is called again after the reading phase when the field has been resolved.
gigerdo
force-pushed
the
fix-nodetypes-failure
branch
from
814b4a2
to
683a03e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error in the validation when using legacy node-type configs.
If the version is unset, the validation crashes with an error. This can happen in certain scenarios: When using a reference (e.g.
data.ec_stack.latest.version) it will not be resolved in a first phase when this validation is called. In such cases the validation should be skipped.The validation still works as it is called again after the reading phase when the field has been resolved.
Related Issues
#734
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist