Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #581

Open
ErikPelli opened this issue Dec 20, 2024 · 0 comments
Open

Refactor tests #581

ErikPelli opened this issue Dec 20, 2024 · 0 comments

Comments

@ErikPelli
Copy link
Collaborator

ErikPelli commented Dec 20, 2024 •
edited
Loading

Current tests are legacy and really old, no one cared much about them.
Failing tests are not reporting the errors to the pipeline result, the whole pipeline should fail, and not report a success.

  1. Try to fix the commented tests
  2. Rewrite them, evaluating some library like testify for the common conditional cases
  3. Refactor the code of the tests to make them more clear
  4. Add tests made by Stripe in their fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ErikPelli