You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't know whether this should be considered as a bug, but I see that timeout timers are not cleared even if the request promise has been resolved or rejected. Here is the relevant code line.
If you need an idea of how this can be fixed look at the following axios code snippet.
I think it's important to clear timers so that resources are not wasted without any purpose. As far as I can see, to implement this feature we need to call clearTimeout in the following cases:
Promise resolved
Promise rejected
AbortController called abort
The text was updated successfully, but these errors were encountered:
I don't know whether this should be considered as a bug, but I see that timeout timers are not cleared even if the request promise has been resolved or rejected
It's a bug indeed, I just released a new version with the fix. Thanks for pointing this out! 👍
Hi, thanks for this great library.
I don't know whether this should be considered as a bug, but I see that timeout timers are not cleared even if the request promise has been resolved or rejected. Here is the relevant code line.
If you need an idea of how this can be fixed look at the following axios code snippet.
I think it's important to clear timers so that resources are not wasted without any purpose. As far as I can see, to implement this feature we need to call
clearTimeout
in the following cases:abort
The text was updated successfully, but these errors were encountered: