Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fail with OpenSSL 3 #37

Closed
espen opened this issue Nov 6, 2023 · 1 comment
Closed

Test fail with OpenSSL 3 #37

espen opened this issue Nov 6, 2023 · 1 comment

Comments

@espen
Copy link
Contributor

espen commented Nov 6, 2023

Encountered an error while trying to do some changes to this gem.

  1) LetsEncrypt::Certificate#active? return true when certificate exists
     Failure/Error: certificate.present?
     
     OpenSSL::X509::CertificateError:
       ASN1 lib
     # ./app/models/lets_encrypt/certificate.rb:44:in `active?'
     # ./spec/models/lets_encrypt/certificate_spec.rb:16:in `block (3 levels) in <top (required)>'

Using openssl v 2.2.3 works.

Looks like OpenSSL v3 will fail for empty certificate: OpenSSL::X509::Certificate.new used in certificate_spec.rb. Yields a certificate when doing to_s on 2.2.3 but not in 3.x.

@elct9620
Copy link
Owner

elct9620 commented Nov 6, 2023

ruby/openssl#369

Seems to have some issues to support OpenSSL 3 🤔

According to the Ruby document to create a new certificate but #to_pem #to_der are not work.
https://docs.ruby-lang.org/en/3.2/OpenSSL.html#module-OpenSSL-label-Creating+a+Certificate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants