Some features and a bug fix #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.3.6
Update softDepends
Added a SaberFactions integration
maximumStacking: the maximum amount of entities that can be stacked through stacking. 0 = infinite stacking since you can disable stacking with allowStacking maximumSelfCarry: The maximum amount of entities a player can pick without stacking bypass.maxstack: infinite stacking regardless of maxStack bypass.maxselfcarry: infinitely picking up mobs regardless of maxSelfCarry
Fixed eldoriarpg#6 Configurable throw delay
java.lang.ClassCastException: class java.lang.Integer cannot be cast to class java.lang.Long
rainbowdashlabs
requested changes
Sep 8, 2022
src/main/java/de/eldoria/pickmeup/services/ProtectionService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/eldoria/pickmeup/services/ProtectionService.java
Outdated
Show resolved
Hide resolved
This takes account for all dismount events, such as disconnect, Entity#removePassenger, the passenger dismounting for any reason, etc.
Changed version of Saber-Factions to 2.9.1-RC
getPlugin() returns the Towny plugin Instance.
Moved some stuff around to simplify the logic
Implemented eldoriarpg#7 However this comes with a drawback. In order to achieve this, I'm adding an invisible baby armor stand as a buffer between the player and the entitiy it is holding, this comes with the drawback of obstructing the player's ability to interact/attack any other block or entity. The only ones capable of circumbenting this naturally are bedrock player's or modded clients. To the moment, the only way I've found to fix this is to teleport the armorstand on top of the player every tick instead, however, this makes the entities lag behind when running.
Commenting this in the case it could be rescued later, for now it has no use because of 616df31 Now right/left clicking while on SNEAK_THROW state, cancels the throw and switches you to SNEAK_MOUNT, which will allow you to stand back up without dropping the entity
Forgot to make the offsetter armorstand invisible and invulnerable
Adding this as afailsafe to ensure the function of the plugin
The offsetter armorstand wasn't being properly removed when no more entities where mounted on them
rainbowdashlabs
requested changes
Sep 13, 2022
There was a problem hiding this comment.
The last changes. Please refrain from adding more features into this pull request. you can do this on another PR later. Hacktober is coming as well ^^ I need to do some testing on my own still. So far I only see mostly structural or formatting issues. But the logic seems to be fine
| allowStacking = map.getValueOrDefault("allowStacking", allowStacking); | ||
| maximumStacking = map.getValueOrDefault("maximumStacking", maximumStacking); | ||
| //maximumSelfCarry = map.getValueOrDefault("maximumSelfCarry", maximumSelfCarry); |
There was a problem hiding this comment.
I was leaving it on the chance it could be rescued later
| @@ -6,6 +6,8 @@ public final class Permissions { | |||
| public static final String BASE = "pickmeup."; | |||
| public static final String RELOAD = BASE + "reload"; | |||
| public static final String BYPASS_NOSTACK = BASE + "bypass.nostack"; | |||
| public static final String BYPASS_MAXSTACK = BASE + "bypass.maxstack"; | |||
| //public static final String BYPASS_MAXSELFCARRY = BASE + "bypass.maxselfcarry"; | |||
Co-authored-by: Lilly Tempest <46890129+RainbowDashLabs@users.noreply.github.com>
IsOffsetter causes an error, changed it to is-offsetter
rainbowdashlabs
requested changes
Oct 7, 2022
There was a problem hiding this comment.
Sorry for the long wait. I was caught up in work after my holidays and some other projects.
I found the time to test your changes in depth now myself.
- The offset armorstand does not get removed when the server stops while the mob is mounted. This results in the mob floating on an armor stand, which cant be destroyed on restart.
- Using creative a left click above the hat of someone carrying a mob destroys the armor stand, which results in dropping the mob. Doesnt work in survival so its a minor issue for now.
- throwing works flawlessly and the rest of the functions. Good job!
Please fix the restart issue and I would be more than happy to merge your pull request!
I have bedrock users on my server and they are able to carry entities just fine. All you have to do is tap and hold the entity. If this is added please consider making it togglable through a config setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extra features
Fixed #6
Carrying can now be done with either right or left click, this is to enable Bedrock players to pick up mobs too