-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to build NSIS installer on Mac: NSIS_CONFIG_LOG not defined #32
Comments
@develar would you be able to upload a v3.0.4.2 (incl. Log + StrLength) for MacOS? Right now I receive
This is probably a blocker for this feature to be added to electron-builder electron-userland/electron-builder#6024 as NSIS tests with 3.0.4.2 pass on Windows, but fail on Mac. Alternatively, we could add electron-builder NSIS logging to be a windows-only feature for an initial release, but if it'd be possible to have a 3.0.4.2 mac makensis compiled, I think it'd\ be the best route for our userbase. |
Any progress on this one? Right now I make all my Windows NSIS builds on a Mac and it would be nice to be able to do so with logging enabled. |
I am experiencing a failure to build Windows NSIS installer/uninstaller on macOS, whenever the installer.nsh script references
LogSet
and/orLogText
. If I comment those out, it builds fine. Here is the error I'm getting:Based on my understanding, the 3.0.4.2 version of the NSIS binary from this repo should contain the fix to set
NSIS_CONFIG_LOG=1
, in this commit 0a8031d. Therefore, logging should be enabled. Building on Windows has no problem.It would be great to know if this is an issue with building for NSIS logging on Mac, or if something is wrong in my configuration. Thank you.
The text was updated successfully, but these errors were encountered: