feat: add node-gyp-rebuild #683

package.json

@@ -13,7 +13,8 @@
   "bin": {
     "build": "./out/build-cli.js",
     "cleanup": "./out/cleanup.js",
-    "install-app-deps": "./out/install-app-deps.js"
+    "install-app-deps": "./out/install-app-deps.js",
+    "node-gyp-rebuild": "./out/node-gyp-rebuild.js"
   },
   "scripts": {
     "compile": "npm run compile-production && npm run compile-test && npm run compile-updater",

src/node-gyp-rebuild.ts

@@ -0,0 +1,34 @@
+#! /usr/bin/env node
+
+import { getElectronVersion, exec, getGypEnv } from "./util/util"
+import { printErrorAndExit } from "./util/promise"
+import * as path from "path"
+import yargs = require("yargs")
+import { readPackageJson } from "./util/readPackageJson"
+import { log } from "./util/log"
+
+//noinspection JSUnusedLocalSymbols
+const __awaiter = require("./util/awaiter")
+
+const args: any = yargs
+  .option("arch", {
+    choices: ["ia32", "x64"],
+  }).argv
+
+const projectDir = process.cwd()
+const devPackageFile = path.join(projectDir, "package.json")
+
+async function main() {
+  const arch = args.arch || process.arch
+  log(`Execute node-gyp rebuild for arch ${arch}`)
+  await exec(process.platform === "win32" ? "node-gyp.cmd" : "node-gyp", ["rebuild"], {
+    env: getGypEnv(await getElectronVersion(await readPackageJson(devPackageFile), devPackageFile), arch),
+  })
+}
+
+try {
+  main()
+}
+catch (e) {
+  printErrorAndExit(e)
+}

src/packager.ts

@@ -216,7 +216,7 @@ export class Packager implements BuildInfo {
 
   private async installAppDependencies(platform: Platform, arch: Arch): Promise<any> {
     if (this.devMetadata.build.nodeGypRebuild === true) {
-      log("Execute node-gyp rebuild")
+      log(`Execute node-gyp rebuild for arch ${Arch[arch]}`)
       await exec(process.platform === "win32" ? "node-gyp.cmd" : "node-gyp", ["rebuild"], {
         env: getGypEnv(this.electronVersion, Arch[arch]),
       })

src/publish/gitHubPublisher.ts

@@ -184,4 +184,11 @@ export class GitHubPublisher implements Publisher {
 
     warn(`Cannot delete release ${release.id}`)
   }
+
+  // async deleteOldReleases() {
+  //   const releases = await githubRequest<Array<Release>>(`/repos/${this.owner}/${this.repo}/releases`, this.token)
+  //   for (let release of releases) {
+  //     await githubRequest(`/repos/${this.owner}/${this.repo}/releases/${release.id}`, this.token, null, "DELETE")
+  //   }
+  // }
 }

test/src/ArtifactPublisherTest.ts

@@ -104,6 +104,8 @@ testAndIgnoreApiRate("incorrect tag name", async () => {
     prerelease: true,
     publish: "onTagOrDraft",
   })
+
+  // await publisher.deleteOldReleases()
   try {
     await publisher.releasePromise
     //noinspection ExceptionCaughtLocallyJS