Auto update on macOS #1315

dventurino · 2017-03-01T08:58:52Z

electron-builder 14.5.2

electron-updater 1.8.1

Target: mac

Similarly to issue #1310 , I'm setting up the auto-update feature on macOS as well. The publishing process is ok, but I've got an error during the update process:

if there is no update, everything is ok and I receive the "No update available" message correctly, but
if there is an update, I get this:

[Wed Mar 01 2017 09:55:58 GMT+0100 (CET)] INFO Checking for update
[Wed Mar 01 2017 09:55:58 GMT+0100 (CET)] INFO Checking for update...
[Wed Mar 01 2017 09:55:59 GMT+0100 (CET)] ERROR Error: TypeError: this.logger.warn is not a function
    at AutoUpdater.MacUpdater.nativeUpdater.on.it (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/MacUpdater.ts:16:21)
    at emitTwo (events.js:106:13)
    at AutoUpdater.emit (events.js:191:7)
    at MacUpdater.onUpdateAvailable (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/MacUpdater.ts:29:24)
    at /Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:187:10
From previous event:
    at MacUpdater.doCheckForUpdates (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:237:11)
    at /Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:142:25
    at Generator.next (<anonymous>)
    at runCallback (timers.js:651:20)
    at tryOnImmediate (timers.js:624:5)
    at processImmediate [as _immediateCallback] (timers.js:596:5)
From previous event:
    at MacUpdater._checkForUpdates (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:191:11)
    at MacUpdater.checkForUpdates (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:124:35)
    at Timeout._onTimeout (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/main.js:251:17)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)
[Wed Mar 01 2017 09:55:59 GMT+0100 (CET)] INFO Error in auto-updater.

This is the code looking for any updates:

autoUpdater.on('checking-for-update', () => {
    log.info('Checking for update...');
})
autoUpdater.on('update-available', (ev, info) => {
    log.info('Update available.');
})
autoUpdater.on('update-not-available', (ev, info) => {
    log.info('Update not available.');
})
autoUpdater.on('error', (ev, err) => {
    log.info('Error in auto-updater.');
})
autoUpdater.on('download-progress', (ev, progressObj) => {
    log.info('Downloading update...');
})
autoUpdater.on('update-downloaded', (ev, info) => {
    log.info('Update downloaded.  Will quit and install in 5 seconds.');
    // Wait 5 seconds, then quit and install
    setTimeout(function () {
        autoUpdater.quitAndInstall();
    }, 5000)
})
// Wait a second for the window to exist before checking for updates.
setTimeout(function () {
    autoUpdater.checkForUpdates();
}, 1000);

The text was updated successfully, but these errors were encountered:

develar · 2017-03-01T20:30:54Z

Is debug logging enabled?

dventurino · 2017-03-02T08:06:50Z

Yep, this is what I see in my logs:

[Wed Mar 01 2017 09:55:58 GMT+0100 (CET)] INFO Checking for update
[Wed Mar 01 2017 09:55:58 GMT+0100 (CET)] INFO Checking for update...
[Wed Mar 01 2017 09:55:59 GMT+0100 (CET)] ERROR Error: TypeError: this.logger.warn is not a function
    at AutoUpdater.MacUpdater.nativeUpdater.on.it (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/MacUpdater.ts:16:21)
    at emitTwo (events.js:106:13)
    at AutoUpdater.emit (events.js:191:7)
    at MacUpdater.onUpdateAvailable (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/MacUpdater.ts:29:24)
    at /Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:187:10
From previous event:
    at MacUpdater.doCheckForUpdates (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:237:11)
    at /Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:142:25
    at Generator.next (<anonymous>)
    at runCallback (timers.js:651:20)
    at tryOnImmediate (timers.js:624:5)
    at processImmediate [as _immediateCallback] (timers.js:596:5)
From previous event:
    at MacUpdater._checkForUpdates (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/out/AppUpdater.js:191:11)
    at MacUpdater.checkForUpdates (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:124:35)
    at Timeout._onTimeout (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/main.js:251:17)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)
[Wed Mar 01 2017 09:55:59 GMT+0100 (CET)] INFO Error in auto-updater.

develar · 2017-03-02T08:11:14Z

I cannot yet check code, but you can try to: logger.warn = logger.info

dventurino · 2017-03-02T09:10:24Z

That seems to have fixed it. I still have some error because the app is not correctly signed, but I'll look into it as soon as I can

dventurino · 2017-03-03T08:45:01Z

I get a warning about the application not being signed (and it's not yet), then the new version on s3 is detected as an available update, but the download does not start or it gets stuck.

Here are the logs:

INFO Checking for update
INFO Checking for update...
DEBUG { Error: Could not get code signature for running application
at MacUpdater.onUpdateAvailable (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/MacUpdater.ts:29:24)
at /Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:187:10
at Generator.next ()
at Generator.tryCatcher (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/util.js:16:23)
at PromiseSpawn._promiseFulfilled (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/generators.js:97:49)
at Async._drainQueue (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/async.js:138:12)
at Async._drainQueues (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/async.js:143:10)
at Immediate.Async.drainQueues (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/async.js:17:14)
at runCallback (timers.js:651:20)
at tryOnImmediate (timers.js:624:5)
at processImmediate [as _immediateCallback] (timers.js:596:5)
preventDefault: [Function: preventDefault],
sender:
AutoUpdater {
_events: { error: [Function], 'update-downloaded': [Function] },
_eventsCount: 2 } }
ERROR Error: Error: Could not get code signature for running application
at MacUpdater.onUpdateAvailable (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/MacUpdater.ts:29:24)
at /Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/electron-updater/src/AppUpdater.ts:187:10
at Generator.next ()
at Generator.tryCatcher (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/util.js:16:23)
at PromiseSpawn._promiseFulfilled (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/generators.js:97:49)
at Async._drainQueue (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/async.js:138:12)
at Async._drainQueues (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/async.js:143:10)
at Immediate.Async.drainQueues (/Users/Daniele/git/box/dist/mac/box.app/Contents/Resources/app.asar/node_modules/bluebird/js/release/async.js:17:14)
at runCallback (timers.js:651:20)
at tryOnImmediate (timers.js:624:5)
at processImmediate [as _immediateCallback] (timers.js:596:5)
INFO Error in auto-updater.
INFO Found version 1.0.0 (url: https://mybucket.s3.amazonaws.com/setup/test/box/box-1.0.0-mac.zip)
INFO Update available.
INFO Downloading update from https://mybucket.s3.amazonaws.com/setup/test/box/box-1.0.0-mac.zip

mediaslav · 2017-03-06T19:48:38Z

For Mac autoupdate app is required to be signed

dventurino · 2017-03-07T10:55:37Z

@develar is the signature mandatory even for testing purposes ?

develar · 2017-03-07T11:00:12Z

Always required. You can use free Mac Developer cert. It is Squirrel.Mac requirement.

dventurino · 2017-03-07T13:48:40Z

👍 ok I tried a dummy Mac Developer certificate and it worked!

Now I've got to generate a good one. I do not use Xcode, but maybe there is a way to get one without it. Thanks again

AlienHoboken · 2017-03-23T06:12:08Z

Move to close?

ccnokes · 2017-03-29T17:53:45Z

This is not related to this issue (sorry). @dventurino where do you get the free/dummy mac dev certificate?

develar · 2017-03-29T17:55:42Z

This issue is not closed because TypeError: this.logger.warn is not a function is not yet investigated and fixed.

dventurino · 2017-03-30T07:03:10Z

@ccnokes I had a mac development certificate generated on machine (with Xcode) at work. It's good enough for development purpouse, but not for production.

alexcroox · 2017-05-29T13:00:21Z

@dventurino Where in Xcode do you create this? I'd created my own in osx keychain before but not sure where to get a free "mac development" one from within Xcode?

dventurino · 2017-05-30T08:41:25Z

@alexcroox
Xcode -> Preferences -> Account -> Manage certificates -> + -> macOs Development

alexcroox · 2017-05-30T20:13:50Z

@dventurino thanks, and I assume if I'm exporting this I can share with other team mates who can use it to sign new releases from their own machines with it? (it's an internal tool so a development cert is fine for auto updates)

bill-pixvana · 2017-05-30T23:19:25Z

Yes, I use Keychain Access to export the credential and key as a .p12 to be imported on another mac via Keychain Access.

dventurino · 2017-05-31T07:05:52Z

@alexcroox yep! As @bill-pixvana said, you just have to share with them the .p12 file.

develar · 2017-06-05T17:26:33Z

TypeError — Obsolete since electron-updater 2.0.0 (will be released today).

develar added electron-updater reply-needed labels Mar 1, 2017

dventurino mentioned this issue Mar 3, 2017

Auto-updater and Windows #1327

Closed

develar added bug and removed reply-needed labels Mar 7, 2017

develar closed this as completed Jun 5, 2017

develar added the obsolete label Jun 5, 2017

ebshimizu mentioned this issue Mar 20, 2018

macOS: Auto-update may fail ebshimizu/stats-of-the-storm#132

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto update on macOS #1315

Auto update on macOS #1315

dventurino commented Mar 1, 2017

develar commented Mar 1, 2017

dventurino commented Mar 2, 2017 •

edited

Loading

develar commented Mar 2, 2017

dventurino commented Mar 2, 2017

dventurino commented Mar 3, 2017 •

edited

Loading

mediaslav commented Mar 6, 2017

dventurino commented Mar 7, 2017

develar commented Mar 7, 2017 •

edited

Loading

dventurino commented Mar 7, 2017

AlienHoboken commented Mar 23, 2017

ccnokes commented Mar 29, 2017

develar commented Mar 29, 2017

dventurino commented Mar 30, 2017

alexcroox commented May 29, 2017 •

edited

Loading

dventurino commented May 30, 2017

alexcroox commented May 30, 2017

bill-pixvana commented May 30, 2017

dventurino commented May 31, 2017

develar commented Jun 5, 2017

Auto update on macOS #1315

Auto update on macOS #1315

Comments

dventurino commented Mar 1, 2017

develar commented Mar 1, 2017

dventurino commented Mar 2, 2017 • edited Loading

develar commented Mar 2, 2017

dventurino commented Mar 2, 2017

dventurino commented Mar 3, 2017 • edited Loading

mediaslav commented Mar 6, 2017

dventurino commented Mar 7, 2017

develar commented Mar 7, 2017 • edited Loading

dventurino commented Mar 7, 2017

AlienHoboken commented Mar 23, 2017

ccnokes commented Mar 29, 2017

develar commented Mar 29, 2017

dventurino commented Mar 30, 2017

alexcroox commented May 29, 2017 • edited Loading

dventurino commented May 30, 2017

alexcroox commented May 30, 2017

bill-pixvana commented May 30, 2017

dventurino commented May 31, 2017

develar commented Jun 5, 2017

dventurino commented Mar 2, 2017 •

edited

Loading

dventurino commented Mar 3, 2017 •

edited

Loading

develar commented Mar 7, 2017 •

edited

Loading

alexcroox commented May 29, 2017 •

edited

Loading