Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable automatic detection of publish settings #1334

Closed
drew-gross opened this issue Mar 6, 2017 · 3 comments · May be fixed by qcif/data-curator#563
Closed

Add option to disable automatic detection of publish settings #1334

drew-gross opened this issue Mar 6, 2017 · 3 comments · May be fixed by qcif/data-curator#563

Comments

@drew-gross
Copy link

I recently spent a bunch of time debugging an issue where my environment had AWS_SECRET_ACCESS_KEY set for reasons unrelated to the electron project I was working on. This resulted in a very unhelpful error: Error: Please specify "bucket" for "s3" update server which seemed crazy to me because nothing anywhere in my project used s3 or aws. I eventually discovered #1270 which led me to check my env, where I found the AWS_SECRET_ACCESS_KEY.

I suggest that you add an option to disable all implicit detection of build or publish settings, I would much rather specify everything explicitly, as I find this type of magic auto-detection fails in very hard to debug ways. Otherwise, I suggest adding info about what settings have been auto-detected and how, for example: Attempting to publish to s3 because AWS_SECRET_ACCESS_KEY is set. Error: Could not find "bucket" setting.

@develar
Copy link
Member

develar commented Mar 6, 2017

Set publish to null to disable auto detection.

@develar
Copy link
Member

develar commented Mar 6, 2017

Hmm... No, you don't need to set it to null. Env must be not detected if no explicit config for s3.

@develar develar changed the title [Feature request] Add option to disable automatic detection of publish settings Add option to disable automatic detection of publish settings Mar 6, 2017
@develar develar closed this as completed in c4744af Mar 6, 2017
@develar
Copy link
Member

develar commented Mar 6, 2017

Fixed in 15.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants