Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Linux) Package-specific depends broken, breaking Trays & Notifications #1338

Closed
sidneys opened this issue Mar 7, 2017 · 0 comments · May be fixed by qcif/data-curator#563
Closed

(Linux) Package-specific depends broken, breaking Trays & Notifications #1338

sidneys opened this issue Mar 7, 2017 · 0 comments · May be fixed by qcif/data-curator#563

Comments

@sidneys
Copy link
Contributor

sidneys commented Mar 7, 2017

  • Version: 15.1.1
  • Target: Linux

In earlier releases (up to 11.5.1), specifying an Array within build.target.depends allowed to specify target-specific package dependencies.

With the newly introduced package.json validation not allowing build.target.depends, (e.g. build.pacman.depends, build.rpm.depends) and throwing additionalProperties error, this has become impossible:

Raw validation errors: [
  {
    "keyword": "additionalProperties",
    "dataPath": "",
    "schemaPath": "#/additionalProperties",
    "params": {
      "additionalProperty": "pacman"
    },
    "message": "should NOT have additional properties"
  },
  {
    "keyword": "additionalProperties",
    "dataPath": "",
    "schemaPath": "#/additionalProperties",
    "params": {
      "additionalProperty": "rpm"
    },
    "message": "should NOT have additional properties"
  }
]

This feature is crucial for apps using Tray Menus or Notifications, requiring libappindicator and libnotify packages, but which are named slightly different on every target:

  • deb
    correctly includes libnotify4, libappindicator1
  • pacman
    misses libappindicator-gtk2, libappindicator-gtk3, libappindicator-sharp, libnotify
  • rpm
    misses libappindicator, libnotify

With the newly introduced package.json validation not allowing for custom depends for these formats, its not possible anymore to install them, rendering the installer useless.

Can anyone help?

@sidneys sidneys changed the title (Linux) Package-specific depends are broken, breaking Tray- & Notification-based apps (Linux) Package-specific depends broken, breaking Trays & Notifications Mar 7, 2017
This was referenced Mar 7, 2017
@develar develar closed this as completed in 79c94bd Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant