Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asar: false, causing exception on app startup with v16.4.0 #1409

Closed
dharders opened this issue Mar 27, 2017 · 6 comments · May be fixed by qcif/data-curator#563
Closed

Asar: false, causing exception on app startup with v16.4.0 #1409

dharders opened this issue Mar 27, 2017 · 6 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@dharders
Copy link

  • Version: 16.4.0
  • Target: Win64 NSIS

Just updated from 15.4.3 to 16.4.0

Received the following exception on App startup (install OK):

A JavaScript error occurred in the main process
Uncaught Exception:
Error: Unable to find a valid app at Object. ......\resources\electron.asar\browser\init....:9

If I set asar: true, all is good.

I use asar: false during development.

Build Config:

"build": {
    "appId": "com.myapp.myapp",
    "asar": false,
    "productName": "My App",
    "compression": "store",
    "npmRebuild": false,
    "win": {
      "target": [
        "nsis"
      ],
      "certificateSubjectName": "My Cert",
      "legalTrademarks": "My Trademark™"
    },    
    "nsis": {
      "perMachine": false,
      "allowElevation": true,
      "oneClick": true,
      "language": "3081"
    },
    "directories": {
      "buildResources": "resources",
      "output": "package_desktop",
      "app": "dist"
    }
  }
@dharders
Copy link
Author

FYI: just tried v16.3.0 with asar: false and it worked!

Something happened in latest release ;)

@develar develar added the bug label Mar 27, 2017
@dharders
Copy link
Author

Thanks @develar , just tried 16.4.2 with the fix but same exception still occurring on app launch, with asar: false. 16.3.0 last known working version.

@develar
Copy link
Member

develar commented Mar 28, 2017

@dharders Is it possible to provide app for reproduce?

@dharders
Copy link
Author

@develar Sure, here you go https://github.com/dharders/electron-builder-repro-app-issue1409

Instructions are given in the repo README.md

@develar
Copy link
Member

develar commented Mar 29, 2017

Thanks, fix will be in the next release.

@dharders
Copy link
Author

dharders commented Apr 2, 2017

Thanks @develar ! I can confirm this is now working. You're a champion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants