add proxy authentication support to electron-updater #1530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BurningEnlightenment, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kevinphelps, @AlienHoboken and @maczikasz to be potential reviewers. |
Relay "login" events from ElectronHttpExecutor back to the autoUpdater instance, where the user may decide to subscribe to the "login" event.
|
@develar Why does |
|
I think it is bug. |
Shall I add a commit fixing it to this PR? |
|
Yes, please. |
develar
added a commit
to develar/electron-builder
that referenced
this pull request
May 7, 2017
|
Danke! |
|
electron-updater 1.15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this approach we simply relay the login event from the electron requests to the
autoUpdaterinstance through a callback provided by an (optional) constructor parameter ofElectronHttpExecutor.The test suite runs; but I haven't had time to test the change specifically, but uploaded it in order to allow for early feedback on the general approach.
resolves #1528